Patch here: http://review.source.kitware.com/#/c/6119/
Thanks, Matt On Wed, Jun 6, 2012 at 2:50 PM, Matt McCormick <[email protected]> wrote: > Hi Brad, > > Thanks for the note. I'll start working on a patch. > > Matt > > On Wed, Jun 6, 2012 at 10:04 AM, Bradley Lowekamp > <[email protected]> wrote: >> Hi Matt, >> >> Thanks for letting us know you are taking up this responsibility. >> >> I noticed that Valgrind has a dozen defects related to the new FEM test from >> this patch: >> >> http://open.cdash.org/viewDynamicAnalysis.php?buildid=2339087 >> >> Thanks, >> Brad >> >> On Jun 5, 2012, at 12:07 PM, Matt McCormick wrote: >> >> On Mon, Jun 4, 2012 at 10:16 PM, Bradley Lowekamp >> <[email protected]> wrote: >> >> Matt, >> >> >> It sounds like it has been review and test about as good as it can be in >> gerrit ( after Bill's review of course ). >> >> >> I would like to know that the developers of the patch are planning to >> working on addressing the likely dashboard issue that show up on Tuesday >> nights dashboard on Wednesday, before this patched is merged. Because it >> would be great it the dashboard is cleaned up in time for Friday's TCON, to >> make the tag then. >> >> >> >> Merged so we have a few days to iron out any remaining issues. I will >> take responsibility for any build or test failures that are not >> addressed. >> >> Thanks, >> Matt >> >> On Jun 4, 2012, at 9:41 PM, Matt McCormick wrote: >> >> >> Hi Bill, >> >> >> Here's the link: >> >> >> http://review.source.kitware.com/#/c/5869/ >> >> >> Thanks, >> >> Matt >> >> >> On Mon, Jun 4, 2012 at 8:30 PM, Bill Lorensen <[email protected]> >> wrote: >> >> Matt >> >> >> Which gerrit topic is this? >> >> >> Bill >> >> >> On Mon, Jun 4, 2012 at 6:32 PM, Matt McCormick >> >> <[email protected]> wrote: >> >> Hi all, >> >> >> I think the following A2D2 patch should be merged for this release >> >> candidate cycle. This patch has under development for a long period >> >> of time, and it is currently passing all tests. I do not see related >> >> warnings or build errors on the platforms I have tested. Here are the >> >> results from manual tests on all Linux and Windows platforms, a Mac >> >> build is in process: >> >> >> Linux-Clang: >> >> >> http://open.cdash.org/buildSummary.php?buildid=2334099 >> >> >> Windows - Visual Studio 2010: >> >> >> http://open.cdash.org/buildSummary.php?buildid=2334134 >> >> >> >> Without objection, I will merge tomorrow. >> >> >> Thanks, >> >> Matt >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> Kitware offers ITK Training Courses, for more information visit: >> >> http://kitware.com/products/protraining.php >> >> >> Please keep messages on-topic and check the ITK FAQ at: >> >> http://www.itk.org/Wiki/ITK_FAQ >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://www.itk.org/mailman/listinfo/insight-developers >> >> >> >> >> -- >> >> Unpaid intern in BillsBasement at noware dot com >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> Kitware offers ITK Training Courses, for more information visit: >> >> http://kitware.com/products/protraining.php >> >> >> Please keep messages on-topic and check the ITK FAQ at: >> >> http://www.itk.org/Wiki/ITK_FAQ >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://www.itk.org/mailman/listinfo/insight-developers >> >> >> >> ======================================================== >> >> Bradley Lowekamp >> >> Medical Science and Computing for >> >> Office of High Performance Computing and Communications >> >> National Library of Medicine >> >> [email protected] >> >> >> >> _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
