Kent,

The preferred way is just like ITK.

Run the Utilities/SetupForDevelopement.sh script. Then do a "git gerrit-push".

A few more details are here:
http://www.itk.org/SimpleITKDoxygen/html/Developer.html

But it's really suppose to be the same as ITK to contribute a patch.

Thank you very much for the fix!

Brad


On Aug 14, 2012, at 1:35 PM, Williams, Norman K wrote:

> There was this bug report from Hans:
> https://issues.itk.org/jira/browse/SIMPLEITK-296
> 
> CLang was pickier than our other supported compilers, and unfortunately,
> the fix broke Visual Studio builds.
> 
> I have a patch that fixes this problem with a preprocessor symbol that is
> set to 'template' only for clang, by adding a preprocessor conditional to
> sitConfigure.h.in
> 
> This is in my github fork of SITK:
> https://github.com/BRAINSia/SimpleITK/commits/CLangCompileFix
> 
> So how and to whom should I send this patch?  I don't really follow
> SimpleITK development so I don't know if there's an established SimpleITK
> equivalent of the Gerrit workflow for ITK.
> 
> --
> Kent Williams [email protected]
> 
> 
> 
> 
> 
> 
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by the 
> Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential 
> and may be legally privileged.  If you are not the intended recipient, you 
> are hereby notified that any retention, dissemination, distribution, or 
> copying of this communication is strictly prohibited.  Please reply to the 
> sender that you have received the message in error, then delete it.  Thank 
> you.
> ________________________________
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

========================================================
Bradley Lowekamp  
Medical Science and Computing for
Office of High Performance Computing and Communications
National Library of Medicine 
[email protected]



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-developers

Reply via email to