Thanks for the reviews! On Sat, Dec 8, 2012 at 9:54 PM, Steve M. Robbins <[email protected]> wrote:
> Hello Matt, > > Did not compile with patches, but review comments follow. > > On December 7, 2012 10:28:01 AM Matt McCormick wrote: > > Hi Steve, > > > > Thanks again for you riemann.sumost.ca dashboard submissions. > > > > I created patches to address warnings on that box: > > > > http://review.source.kitware.com/#/c/8846/ > > Looks fine. > > > http://review.source.kitware.com/#/c/8847/ > > While I believe the change is correct, I would have used > IndexType::IndexValueType (for x, y) rather than itk::IndexValueType, to > make > the subsequent line > > const IndexType index = { { x, y } }; > > more clearly correct. > > Cheers, > -Steve > >
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
