+1 to renaming BUILD_ALL_MODULES to BUILD_DEFAULT_MODULES for clarity. +1 to an unexposed BUILD_ALL variable that is enabled for all dashboard builds. I think we should also then turn BUILD_TESTING and BUILD_EXAMPLES OFF by default. A bad impression is made on many beginners by the time a stock build takes.
Matt On Tue, Dec 18, 2012 at 8:26 PM, Bradley Lowekamp <[email protected]> wrote: > BUILD_ALL_MODULES really has turned into just the defaults ones and I am not > sure that is should change much. > > What is really needed is to turn everything on for dashboards and robots. > > I wonder if we could use a new variable... say BUILD_ALL (similar to > BUILD_TESTING, BUILD_EXAMPLES etc..), but not have it in the cache so it's no > it's not exposed to users. It could be defined, in the common nightly build > script, or individual build scripts. > > If this variable is defined it could be used as the default to turn on most > options and modules. This would make it so that people would have to turn off > features on the dashboard instead of enabling them ie turn off GPU or MINC or > what not... > > Just a brainstorming thought... > > > Brad > > > On Dec 18, 2012, at 6:28 PM, Bill Lorensen <[email protected]> wrote: > >> Maybe it should be BUILD_DEFAULT_MODULES? >> >> I agree that BUILD_ALL_MODULES is deceptive. >> >> On Tue, Dec 18, 2012 at 5:13 PM, Sean McBride <[email protected]> >> wrote: >>> Bill, >>> >>> Indeed. But what I meant is that the name "ITK_BUILD_ALL_MODULES" is >>> rather deceptive (reminds me of -Wall). Perhaps it should be named >>> ITK_BUILD_MOST_MODULES or ITK_BUILD_COMMON_MODULES is what I was getting at. >>> >>> Sean >>> >>> >>> On Tue, 18 Dec 2012 12:02:38 -0500, Bill Lorensen said: >>> >>>> Sean, >>>> >>>> It is not on by default. >>>> >>>> Bill >>>> >>>> On Tue, Dec 18, 2012 at 11:11 AM, Sean McBride <[email protected]> >>>> wrote: >>>>> On Tue, 18 Dec 2012 15:48:40 +0000, Williams, Norman K said: >>>>> >>>>>> I should have caught this but like you I didn't have PHilipsRecImageIO >>>>>> turned on. >>>>>> >>>>>> Is there a good reason not to have this ON by default? And I'm all for >>>>>> making all the factory builds turn on everything that's practical to turn >>>>>> on. >>>>> >>>>> I'd like to turn it on on my dashboards, as I use that code. In fact, >>>> I had assumed it was on. I have ITK_BUILD_ALL_MODULES=1, but apparently >>>> that doesn't mean what I thought... >>> >>> >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://www.itk.org/mailman/listinfo/insight-developers > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
