Hi Kent, Thanks for pushing the fix upstream. We also saw many fixes were needed from upstream for Windows at the ITKv4-Slicer hackathon this past week, so it moving the version forward is a good step.
Thanks, Matt On Mon, Jan 14, 2013 at 10:57 AM, Johnson, Hans J <[email protected]> wrote: > Please bring ITK up to speed with DCMTK as a gerrit patch to review. > > Hans > > > On 1/14/13 9:20 AM, "Williams, Norman K" <[email protected]> > wrote: > >>This is a problem I found and reported to the DCMTK developers, and a fix >>has been added to DCMTK. To take advantage of this fix, we'll have to >>either add a patch stage to the existing DCMTK version that ITK checks >>out, or bring forward ITK to a newer DCMTK version. >> >>Some in the ITK developer community are understandably leery of changing >>revisions. Likewise, BRAINSStandAlone (and by extension Slicer) both are >>very conservative about pulling in new versions of ITK. >> >> >>My post is here: >>http://forum.dcmtk.org/viewtopic.php?f=3&t=3628 >> >>Fix is here: >>http://git.dcmtk.org/web?p=dcmtk.git;a=commitdiff;h=aad82710978f74eca1605d >>5 >>eda66f6cc05afffb8 >> >> >>-- >>Kent Williams [email protected] >> >> >> >> >> >> >>On 1/13/13 9:17 AM, "Johnson, Hans J" <[email protected]> wrote: >> >>> >>> >>>Module_ITKDCMTK >>> >>> >>>/Users/johnsonhj/Dashboard/src/ITK-clang31/Modules/ThirdParty/DCMTK/ITKDC >>>M >>>TK_ExtProject/dcmnet/libsrc/dwrap.c:35:21: error: use of undeclared >>>identifier 'LOG_WARNING' >>>int deny_severity = LOG_WARNING; >>> ^ >>>/Users/johnsonhj/Dashboard/src/ITK-clang31/Modules/ThirdParty/DCMTK/ITKDC >>>M >>>TK_ExtProject/dcmnet/libsrc/dwrap.c:36:22: error: use of undeclared >>>identifier 'LOG_INFO' >>>int allow_severity = LOG_INFO; >>> ^ >>>2 errors generated. >>>make[5]: *** [dcmnet/libsrc/CMakeFiles/dcmnet.dir/dwrap.c.o] Error 1 >>>make[4]: *** [dcmnet/libsrc/CMakeFiles/dcmnet.dir/all] Error 2 >>>make[3]: *** [all] Error 2 >>>make[2]: *** >>>[Modules/ThirdParty/DCMTK/ITKDCMTK_ExtProject-prefix/src/ITKDCMTK_ExtProj >>>e >>>ct-stamp/ITKDCMTK_ExtProject-build] Error 2 >>>make[1]: *** >>>[Modules/ThirdParty/DCMTK/CMakeFiles/ITKDCMTK_ExtProject.dir/all] Error 2 >>>make: *** [all] Error 2 >>> >>> >>> >>>Fix may be as simple as updating DCMTK to new version. DCMTK recently >>>had changes for Slicer compatibility that will likely benefit ITK as >>>well. >>> >>> >>>Hans >>> >>> >> > > > > ________________________________ > Notice: This UI Health Care e-mail (including attachments) is covered by the > Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential > and may be legally privileged. If you are not the intended recipient, you > are hereby notified that any retention, dissemination, distribution, or > copying of this communication is strictly prohibited. Please reply to the > sender that you have received the message in error, then delete it. Thank > you. > ________________________________ > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
