Brian, I'd like to revisit this again. I think it may be short-sighted to only use double precision in the optimizers, many cases can benefit significantly by using the less precise and much faster single precision floating point.
I've seen dramatic speed benefits from using single precision floating point rather than double precision. Hans ================================================================= Hans J. Johnson, Ph.D. Assistant Professor, Department of Psychiatry Mailing Address: W274 GH Email: [email protected] 200 Hawkins Drive Phone: (319) 353 8587 The University of Iowa Iowa City, IA 52242 -----Original Message----- From: Brian Avants <[email protected]> Date: Thursday, January 17, 2013 9:59 AM To: Nick Tustison <[email protected]> Cc: ITK <[email protected]> Subject: Re: [Insight-developers] image PixelType when using RegistrationMetricv4 hi nick , xiaoxiao it's the optimization framework that forced this - michael stauffer did a pass through rewriting the optimization framework with a template parameter but this was nixed in one of the developer meetings. agree that it's not ideal --- however, upside is that solutions should be more stable/precise, to state the obvious. b brian On Thu, Jan 17, 2013 at 10:55 AM, Nicholas Tustison <[email protected]> wrote: > Yeah, this is a legacy issue that we need to address but I don't know how > easy it's going to be. It's due to the fact that the transform framework > requires > double type which predates our work. Brian, Michael and I will have to > discuss this to see if we can fix it or at least minimize the places >where > double > is required. > > Nick > > > On Jan 17, 2013, at 10:50 AM, Xiaoxiao Liu <[email protected]> >wrote: > > Hi Nick, > With the recent changes in the RegistrationMetricv4, seems that the > PixeType of an image needs to be always set to double? > Old registration code that with float type fails to compile, but runs > fine with double : > >https://github.com/InsightSoftwareConsortium/ITKv4-TheNextGeneration-Tutor >ial/commit/20df5ac66d43061b5d1ca3665dd1712a5986a879 > The internal parameter measurements are using double, but is there a > reason to require the image type to be double as well? Am I missing > something? > Please give me some pointers. Thanks. > > -- Xiaoxiao > > > --------------------------------------------- > Xiaoxiao Liu, Ph.D. > R & D Engineer > Kitware Inc. > Clifton Park, NY > Phone: (518) 881-4924 or (518) 371-3971 x124 > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers ________________________________ Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. ________________________________ _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
