Actually yes the current gerrit patch will do whatever find_package(DCMTK NO_MODULE) does when the DCMTKConfig.cmake file doesn't have the proper NO_MODULE stuff. -- Kent Williams [email protected]
On 2/22/13 2:50 PM, "Matthew McCormick (thewtex)" <[email protected]> wrote: >Is it possible to fail if the DCMTK version does not have your patch? > >On Fri, Feb 22, 2013 at 7:47 PM, Williams, Norman K ><[email protected]> wrote: >> SoŠ this one is kind of a thing that has a lot of moving parts. >> >> 1. I have a patch submitted to DCMTK, that properly generates >> DCMTKConfig.cmake & other files, to support find_package(DCMTK >>NO_MODULE). >> This is currently a branch on the InsightSoftwareConsortium/DCMTK repo >>we >> set up a couple of weeks ago: >> https://github.com/InsightSoftwareConsortium/DCMTK/tree/AddProperConfig >> >> 2. I have a gerrit topic here http://review.source.kitware.com/#/c/9954/ >> That is designed to build against the fixed DCMTK. >> >> 3. I have a text fixture project on Github that combines all these >>things: >> https://github.com/Chaircrusher/DCMTK_ITK_TESTFIXTURE >> >> Now the ultimate goal is that everyone (where for me that means ITK, >> BRAINSTools, Slicer) use the find_package(DCMTK NO_MODULE) syntax; this >>is >> ultimately a more robust solution. The problem is in the near term, >>there >> are too many dependent things going on. >> >> My patch for ITK depends on the patched DCMTK. It might be possible to >> maintain backwards compatibility with the old find_package and unpatched >> DCMTK, but I'm not sure how to implement that. Would it be as simple as >> this? >> >> find_package(DCMTK NO_MODULE QUIET) >> if(NOT DCMTK_FOUND) >> find_package(DCMTK REQUIRED QUIET) >> if(NOT DCMTK_FOUND) >> message(FATAL_ERROR "DCMTK package not found. Please set DCMTK_DIR >>and >> re-run CMake") >> endif() >> endif() >> -- >> Kent Williams [email protected] >> >> >> >> >> >> >> ________________________________ >> Notice: This UI Health Care e-mail (including attachments) is covered >>by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >>confidential and may be legally privileged. If you are not the intended >>recipient, you are hereby notified that any retention, dissemination, >>distribution, or copying of this communication is strictly prohibited. >>Please reply to the sender that you have received the message in error, >>then delete it. Thank you. >> ________________________________ >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://www.itk.org/mailman/listinfo/insight-developers ________________________________ Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. ________________________________ _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
