Matt, What is the need for the rush?
This is the first I heard a date for this patch release it was not mentioned at the TCON on friday... Brad On Apr 16, 2013, at 10:49 AM, Matt McCormick <[email protected]> wrote: > Hi Brad, > > Thanks for the note. Those look like good fixes. If they can get > tested on the dashboard, I will include them. Otherwise, they will be > helpful for the 4.4.0 release, which will come soon. Your feedback on > the other patches is also helpful. > > Thanks, > Matt > > On Tue, Apr 16, 2013 at 12:43 PM, Bradley Lowekamp > <[email protected]> wrote: >> Hey Matt, >> >> That is not much notice. There are a couple things I'd like to get done for >> a patch release. Not sure they'll both get there by friday... >> >> 1) This patch which improves FFTW, SWIG, and PCRE external projects: >> >> http://review.source.kitware.com/#/c/10848/ >> >> Numerous people have had trouble building WrapITK where they encounter >> issues with the SWIG external project. This may help some of those cases. >> >> 2) There is an issue with the VectorConfidenceConnected filter with >> VectorImages. I have gotten a segfault in SimpleITK when trying to use it >> this way. I'd really like to track this down. >> >> >> Regarding the proposed patches: >> >> I closely reviewed mine and they look OK. >> >> I don't think it would be a good idea to include Ho Cheung's patch on >> GradientVectorFlow. While it does correct a bug, people are likely using it >> currently and this will change their results, so I don't think it's an ideal >> candiate for a patch release. >> >> Kent's patch: >> >> 943a28a COMP: replace in-line access methods with itk Macros >> >> includes the new itkGetModifiableObjectMacro macro, so I don't think that >> will work. >> >> >> On Apr 15, 2013, at 5:24 PM, Matt McCormick <[email protected]> >> wrote: >> >>> Hi all, >>> >>> I propose that we make a patch release, v4.3.2, on Friday. This would >>> only include only low-risk patches that fix critical issues. I will >>> apply all patches to the release branch, create the tarballs, and test >>> them across platforms. Current patches on the release branch are: >>> >>> >>> Bradley Lowekamp (1): >>> BUG: incorrect CMake variable for system jpeg include >>> >>> Jan Margeta (1): >>> COMP: Added missing header <functional> in itkAnchorCloseImageFilter.h >>> >>> Matthew McCormick (2): >>> COMP: VectorIndexSelectionCastImageFilter extra itk namespace. >>> BUG: Add missing header to the third party TIFF install. >>> >>> Paul Novotny (1): >>> COMP: Build fails with ITK_USE_SYSTEM_TIFF >>> >>> Sean McBride (1): >>> COMP: Handle missing Analyze 7.5 flipped directions >>> >>> Xiaoxiao Liu (1): >>> ENH: Sync python scripts with python3. >>> >>> >>> Looking through the git log, the following look like good candidates >>> to include (assuming they are not fixes for what was introduced since >>> v4.3.0): >>> >>> Bill Lorensen: >>> COMP: Fix compile error in PhilipsRECImageIO >>> BUG: Memory leak after failed RegisterFactory >>> >>> Bradley Lowekamp: >>> COMP: GetTimeVaryingVelocityField methods did not compile >>> BUG: initials Direction IVAR >>> COMP: Address unused parameter warning in GPU code >>> BUG: Only thread 0 should report progress. >>> BUG: Only thread 0 should report progress in LabelMapFilters >>> COMP: Adding missing header >>> >>> David Cole: >>> BUG: Avoid using def file when BUILD_SHARED_LIBS is off >>> BUG: Do not undefine _WIN32_WINNT >>> >>> Dirk Padfield: >>> BUG: CSVFileReader was reading all values as NaN >>> >>> Hans Johnson: >>> COMP: Fix robustness of DCMTK internal builds >>> COMP: Type mis-match for comparison operator >>> >>> Ho Cheung: >>> BUG: GradientVectorFlow should calculate timestep based on image >>> dimension >>> BUG: itkPolyLineParametricPath infinite loop for degenerate paths >>> BUG: Fix ITK Path test failures >>> >>> Julien Malik: >>> BUG: Remove itkLoad definition in JPEG2000ImageIOFactory >>> >>> Kent Williams: >>> COMP: replace in-line access methods with itk Macros >>> COMP: removed warnings on Windows due to generic vs excp obj throw. >>> >>> Manuel Grizonnet: >>> BUG: Inconsistency detected by ld.so due to static const string >>> BUG: Inconsistency detected by ld.so due to static const string >>> >>> Matthew McCormick: >>> COMP: Fix HDF5 unused function for long long on Unix. >>> COMP: Add DLL to PATH for Python tests on Visual Studio. >>> BUG: Fix FFTW install paths in ITKConfig.cmake (ITK-2995). >>> BUG: Add missing header to the third party TIFF install. >>> >>> Paul Novotny: >>> COMP: Fix TIFF on big endian systems >>> >>> Sean McBride: >>> BUG: Handle missing Analyze 7.5 flipped directions >>> >>> Tom Vercauteren: >>> COMP: GPUPDEDeformableRegistrationFilter.cl fails to "compile". >>> >>> >>> Not in that list are DCMTK related patches: >>> >>> COMP: Update DCMTK version to incorporate new fixes. >>> COMP: Use portable method to find source dir & find DCMTK headers >>> COMP: Start using ITKConsortium github to retrieve DCMTK. >>> BUG: Regressions with respect to building DCMTK >>> COMP: Fix robustness of DCMTK internal builds >>> BUG: Do not nullify the DCMTK ExternalProject UPDATE_COMMAND. >>> BUG: Fix DCMTK lib_prefix identification. >>> >>> but these should probably be left for 4.4.0, since I will not have time to >>> sufficiently test them for Friday. >>> >>> Thoughts? Anything I missed? >>> >>> Thanks, >>> Matt >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://www.itk.org/mailman/listinfo/insight-developers >> _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
