On 05/01/2013 01:54 PM, Cory Quammen wrote: > Should the minimum CMake version be set to 2.8.8? Or do we want to go > all the way to 2.8.10?
Go with 2.8.4 because that is the minimum feature set we need. > On Mon, Apr 22, 2013 at 12:00 PM, Ho Cheung <[email protected]> wrote: >> I'd like to chime in that if Visual Studio 2012 support is official it will >> require at least 2.8.10. Users that have VS 2012 can install that version. The constraint comes from their environment, not from the project source, so it does not influence our minimum version. >> On Apr 22, 2013, at 9:50 AM, Andras Lasso <[email protected]> wrote: >> >> Minimum CMake 2.8.8 is strongly recommended for Windows builds that use >> external projects due to >> http://www.cmake.org/Bug/print_bug_page.php?bug_id=12957 (with previous >> CMake versions complex builds randomly failed). We already have code a bit lower than the top line: if(WIN32 OR NOT EXISTS /dev/urandom) cmake_minimum_required(VERSION 2.8.5) endif() Change it to if(WIN32) cmake_minimum_required(VERSION 2.8.8) elseif(NOT EXISTS /dev/urandom) cmake_minimum_required(VERSION 2.8.5) endif() but leave the very top line in the file as cmake_minimum_required(VERSION 2.8.4 FATAL_ERROR) -Brad _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
