Merged to release. Thanks, Matt
On Mon, Feb 10, 2014 at 9:02 AM, Bradley Lowekamp <[email protected]> wrote: > Hello Michka, > > Yes. I based this patch on "v4.5.0" tag, ( not including the SimpleITK patch > or your patch below ). This fixed all linking error message that were of the > form mentioned in JIRA ITK-3229. So I think this is the correct fix for it > not side stepping the issue. > > This patch should be merged into release. > > Brad > > On Feb 7, 2014, at 4:12 PM, Michka Popoff <[email protected]> wrote: > > Is this why there were all these errors when wrapping for python on OS > 10.8.5 with clang 5.0.2 ? > > (Which were fixed with this patch : > http://review.source.kitware.com/#/c/14033/ ) > > Le 7 févr. 2014 à 22:04, Bradley Lowekamp a écrit : > > Hello Folks, > > I updated mini7's continuous to be shared libraries. So that's going to be > all red tomorrow. > > But I have the patch for it here: > http://review.source.kitware.com/#/c/14319/ > > Have a good weekend folks! > Brad > > On Feb 7, 2014, at 2:02 PM, Bradley Lowekamp <[email protected]> wrote: > > Hello, > > As I recently turn on shared libraries for on my Mavericks build, I am > getting many more linking error on the release branch now: > http://open.cdash.org/buildSummary.php?buildid=3211313 > I'll need to look into the further. > > Brad > > On Feb 7, 2014, at 8:35 AM, Brian Helba <[email protected]> wrote: > > Please note, one of the dashboard clients testing the release branch has 16 > new failing tests, as a result of the TIFF patch that was merged yesterday. > > On Feb 7, 2014 8:16 AM, "Bradley Lowekamp" <[email protected]> wrote: >> >> Matt, >> >> Also this patch fixes an infinite loop with libc++: >> >> commit b5dd8d4b9cfa8b798ac182a31dcbdaca290958e5 >> Author: Bradley Lowekamp <[email protected]> >> Date: Sat Jan 18 23:32:15 2014 -0500 >> >> COMP: fix failing voronoi segmentation tests >> >> Internal comp method used for std::sort didn't induce a strict weak >> ordering ( <= vs < ) as required, since it returned true on >> equal. This cause failures likely due to difference algorithms in >> libc++. >> >> Change-Id: Ic4c8f61d53bce6858b4edcd3a93c605271b0c65b >> >> Brad >> >> On Feb 7, 2014, at 8:09 AM, Bradley Lowekamp <[email protected]> >> wrote: >> >> > Matt, >> > >> > I think we should consider including the following patch: >> > >> > commit b5e114f94a7a64ff0c426067335cf3f42976eb29 >> > Author: Hans Johnson <[email protected]> >> > Date: Thu Sep 26 23:51:17 2013 -0500 >> > >> > PERF: Reviewing code for facilitating compiler optimizations >> > >> > The itkLinearInterpolateImageFunction.h is such a core >> > function, it deserves special attention for gaining >> > any amount of speed improvement can help >> > improve the speed of many programs. >> > >> > Change-Id: Ibba6caa0468e850ab6b487565943d07af9f82f8c >> > >> > This will provide a large benefit to many users. >> > >> > Additionally the SCIFIO issue with linked libraries is a good candidate. >> > >> > Brad >> > >> > On Feb 6, 2014, at 12:44 AM, Matt McCormick <[email protected]> >> > wrote: >> > >> >> Hi, >> >> >> >> ITK 4.5 is progressing nicely, and a number of important bug fixes >> >> have been applied. Thanks to everyone that has contributed. We want >> >> to make sure that all low-risk patches that fix critical issues are >> >> included in 4.5.1. The current list (to be pushed following testing) >> >> is >> >> >> >> Bill Lorensen (1): >> >> BUG: Tiff compression was broken and untested >> >> >> >> Bradley Lowekamp (5): >> >> BUG: Correctly re-throw exception to restore AbortEvent, >> >> ProcessAborted >> >> BUG: Adding export specification to Exception objects >> >> BUG: disable ipa-cp-clone in GDCM >> >> COMP: fix unused variable warning in abort test >> >> BUG: Do not throw exception in Probes with mis-matched Stop >> >> >> >> Brian Helba (2): >> >> BUG: Fix uninitialized variable in >> >> GradientRecursiveGaussianImageFilter >> >> BUG: Make all specializations NumericTrails::SetLength re-zero >> >> contents >> >> >> >> Hans Johnson (2): >> >> COMP: SimpleITK linkage failure >> >> BUG: Missing Modified() call >> >> >> >> Luke Bloy (2): >> >> BUG: Fixes itkBoxSpatialObject part of issue ITK-3153 >> >> BUG: Fixes itkImageMaskSpatialObject part of issue ITK-3153 >> >> >> >> Matthew McCormick (2): >> >> COMP: Update libminc to latest version. >> >> BUG: Remove unused itkAffineTransformXX.txt content links. >> >> >> >> Michka Popoff (1): >> >> BUG: Fix for the WrapITK.pth destination path >> >> >> >> Sean McBride (1): >> >> BUG: initialize m_SmallBlock ivar in ctor; fixes garbage read >> >> >> >> Anything missing? >> >> >> >> Thanks, >> >> Matt >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Kitware offers ITK Training Courses, for more information visit: >> >> http://kitware.com/products/protraining.php >> >> >> >> Please keep messages on-topic and check the ITK FAQ at: >> >> http://www.itk.org/Wiki/ITK_FAQ >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://www.itk.org/mailman/listinfo/insight-developers >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Kitware offers ITK Training Courses, for more information visit: >> > http://kitware.com/products/protraining.php >> > >> > Please keep messages on-topic and check the ITK FAQ at: >> > http://www.itk.org/Wiki/ITK_FAQ >> > >> > Follow this link to subscribe/unsubscribe: >> > http://www.itk.org/mailman/listinfo/insight-developers >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://www.itk.org/mailman/listinfo/insight-developers >> _______________________________________________ >> Community mailing list >> [email protected] >> http://public.kitware.com/cgi-bin/mailman/listinfo/community > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers > _______________________________________________ > Community mailing list > [email protected] > http://public.kitware.com/cgi-bin/mailman/listinfo/community > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers > > _______________________________________________ > Community mailing list > [email protected] > http://public.kitware.com/cgi-bin/mailman/listinfo/community > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
