Hello Nick, The patch adds the missing private registration method that results in a link error.
Then the patch adds the correct export specifications so that it can be a shared library on windows, and utilize default internal linkage with GCC. This minimizes the number of symbols exported creating a more efficient library. The one issue here was what to do with the functions in the FDFCommonImage header[1]. I didn't mark them as exported. I think these are more like private methods, so perhaps the header should be moved to the src directory so that it's not installed and not usable outside the module. Brad [1] https://github.com/InsightSoftwareConsortium/itkFDFImageIO/blob/master/include/itkFDFCommonImageIO.h On Nov 25, 2014, at 8:28 PM, Nicholas Tustison <ntusti...@gmail.com> wrote: > Hi Brad, > > I use it for a single collaborator who acquires images in this FDF format. > I apologize but I don’t understand the errors that you’re seeing. Kent and > I updated the code from a contributor who had posted it back in the early > 2000s. I didn’t think there was anything particularly complex about the > code. > > Nick > > > >> On Nov 25, 2014, at 6:17 AM, Bradley Lowekamp <blowek...@mail.nih.gov> wrote: >> >> Hello, >> >> To address compilation errors with FDFImageIO I have a pull request. >> >> https://github.com/InsightSoftwareConsortium/itkFDFImageIO/pull/1 >> >> Reviews are appreciated. >> >> This module does not appear to have been working for a while. Is there >> continued support and usage from the community for this module? >> >> Thanks, >> Brad > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
