Matt, What were the results of this experiment? It'd be nice to clean up the release branch of these failing tests.
And I want to steal the correct solution for SimpleITK too :) Brad On Jul 31, 2015, at 3:29 PM, Matt McCormick <matt.mccorm...@kitware.com> wrote: > Hi Brad, > > Thanks for investigating and getting great information out of git bisect. > > I developed the patch on Gentoo with GCC 4.8.4 / binutils 2.24, and I > have not seen any issues. The eldorado builds on the dashboard are > all Ubuntu 14.04.2, too. I will start an Experimental build with > BUILD_SHARED_LIBS set on eldorado to be sure it can be reproduced. > > Thanks, > Matt > > On Fri, Jul 31, 2015 at 1:03 PM, Bradley Lowekamp > <blowek...@mail.nih.gov> wrote: >> Matt, >> >> I was digging into these test failures: >> >> https://open.cdash.org/viewTest.php?onlyfailed&buildid=3932451 >> >> Here are the results of the git bisect: >> >> 674acdb2dd5546b7045f7253c84e4f9f237405e8 is the first bad commit >> commit 674acdb2dd5546b7045f7253c84e4f9f237405e8 >> Author: Matt McCormick <matt.mccorm...@kitware.com> >> Date: Sun May 31 21:00:55 2015 -0400 >> >> ENH: Use gold linker on Linux with GCC. >> >> >> >> The gold linker is approximately three times as fast as the default >> linker. >> Enable it with GCC 4.8 and newer where it was tested. The gold linker >> only >> works with ELF executables, so it is only enabled for Linux. >> >> >> >> Timing tests: >> >> >> >> Static libs link time: >> >> >> >> ld: 452 sec >> ld-gold: 179 sec >> >> >> >> Shared libs link time, wrapping enabled: >> >> >> >> ld: 164 sec >> ld-gold: 48 sec >> >> >> >> Change-Id: Ic8d9b5132ad6b71e5f100b5436615d6a8fac3e5c >> >> Disabling ld-gold seems to fix the problem. >> >> Versions: >> >> blowekamp@lhcp-vm-ubu14:~/ITK$ gcc --version >> gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4 >> Copyright (C) 2013 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. There is NO >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >> >> blowekamp@lhcp-vm-ubu14:~/ITK$ ld --version >> GNU ld (GNU Binutils for Ubuntu) 2.24 >> Copyright 2013 Free Software Foundation, Inc. >> This program is free software; you may redistribute it under the terms of >> the GNU General Public License version 3 or (at your option) a later >> version. >> This program has absolutely no warranty. >> >> blowekamp@lhcp-vm-ubu14:~/ITK$ lsb_release -a >> No LSB modules are available. >> Distributor ID: Ubuntu >> Description: Ubuntu 14.04.2 LTS >> Release: 14.04 >> Codename: trusty >> >> >> Currently we have a check for using gold with > 4.8.3: >> https://github.com/InsightSoftwareConsortium/ITK/blob/master/CMake/ITKSetStandardCompilerFlags.cmake#L206 >> >> But looking at this change: >> https://github.com/InsightSoftwareConsortium/ITK/commit/102c79bd3bb50cc649f2733c472bdfaa138c453e >> >> We should have know about these related test failures: >> https://github.com/InsightSoftwareConsortium/ITK/commit/102c79bd3bb50cc649f2733c472bdfaa138c453e >> >> So what do you recall about what versions of GCC ld-gold works on? >> >> Thanks, >> Brad >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
