Ok, I'll try and do this tomorrow AM. Unless I'm missing something, currently the test code does not test the "closest point" output at all - if we are to add a useful case we'll have to construct an example where the correct set of of barycentric co-ords exist to exercise that branch.
On Mon, 9 Nov 2015 at 17:08 Matt McCormick <matt.mccorm...@kitware.com> wrote: > Great! > > Instructions can be found here: > > http://www.itk.org/Wiki/ITK/Git > > Please branch off of the "release" branch. > > Thanks, > Matt > > On Mon, Nov 9, 2015 at 4:40 PM, Simon Alexander <skalexan...@gmail.com> > wrote: > > Ok, I'll dig up my notes on how to do that and submit it shortly. Should > > this be done against trunk or a release branch ? > > > > On Mon, 9 Nov 2015 at 16:19 Matt McCormick <matt.mccorm...@kitware.com> > > wrote: > >> > >> Thanks for the patch, Simon! Yes, we can wait until this patch is > >> merged to make the release. As Dzenan recommends, please submit the > >> patch to Gerrit with a verification for > >> itk::TriangleCell::EvaluatePosition in itkTriangleCellTest.cxx. > >> > >> Thanks, > >> Matt > >> > >> On Mon, Nov 9, 2015 at 3:54 PM, Dženan Zukić <dzen...@gmail.com> wrote: > >> > Better submit the usual way. I doubt Matt will include it without the > >> > usual > >> > testing. Add me and Matt as reviewers. > >> > > >> > Regards, > >> > Dženan > >> > > >> > On Mon, Nov 9, 2015 at 3:18 PM, Simon Alexander < > skalexan...@gmail.com> > >> > wrote: > >> >> > >> >> We found this today (patch attached). If 4.8.2 is right around the > >> >> corner, can you consider it for inclusion. If time isn't so short, > >> >> I'll > >> >> submit the usual way.... > >> >> > >> >> cheers, > >> >> Simon > >> >> > >> >> > >> >> > >> >> On Mon, 9 Nov 2015 at 09:57 Matt McCormick < > matt.mccorm...@kitware.com> > >> >> wrote: > >> >>> > >> >>> Thanks! Added. > >> >>> > >> >>> On Mon, Nov 9, 2015 at 9:45 AM, Bradley Lowekamp > >> >>> <blowek...@mail.nih.gov> > >> >>> wrote: > >> >>> > We should consider this: > >> >>> > http://review.source.kitware.com/#/c/20369/ > >> >>> > > >> >>> > This helps with using VS2015 GUI. > >> >>> > > >> >>> > > >> >>> > On Nov 9, 2015, at 9:28 AM, Matt McCormick > >> >>> > <matt.mccorm...@kitware.com> > >> >>> > wrote: > >> >>> > > >> >>> >> Hi, > >> >>> >> > >> >>> >> It is time to make the 4.8.2 release. The following patches are > new > >> >>> >> on > >> >>> >> the release branch since 4.8.1. Is there anything missing? > >> >>> >> > >> >>> >> Thanks, > >> >>> >> Matt > >> >>> >> > >> >>> >> Bradley Lowekamp (4): > >> >>> >> BUG: Avoid potential exception in itk::Object::UnRegister > >> >>> >> BUG: Avoid null deference in PrintSelf with default > >> >>> >> construction > >> >>> >> BUG: Use const pointer in Set method for constant > >> >>> >> ReferenceImage > >> >>> >> ivar > >> >>> >> BUG: Fix segfault when with empty IsolatedWatershed > Threshold > >> >>> >> range > >> >>> >> > >> >>> >> Davis Vigneault (3): > >> >>> >> COMP: Warnings in itkVTKImageExport when compiling with > c++11 > >> >>> >> DOC: Expanded Canny Edge Detection Example > >> >>> >> COMP: Warnings in FFTW Classes when compiling with c++11 > >> >>> >> > >> >>> >> Eugene Prilepin (1): > >> >>> >> BUG: Fix a template name formation in python wrappings > >> >>> >> > >> >>> >> Hans Johnson (5): > >> >>> >> STYLE: Minor code style issues for MGHIO > >> >>> >> COMP: Update to version for WikiExamples > >> >>> >> ENH: Update Sphinx for ITK 4.8.0 > >> >>> >> ENH: Update MGHIO to be shared lib > >> >>> >> BUG: Fix MGHIO to fix write failures > >> >>> >> > >> >>> >> Hyun Jae Kang (4): > >> >>> >> BUG: Fix HDF5 CMake configuration with VS2015 > >> >>> >> BUG: Remove std::cout calls from class > >> >>> >> BUG: itkVTKImageIO class does not handle blank lines in VTK > >> >>> >> file > >> >>> >> header. > >> >>> >> BUG: Fixed older XCode linking error > >> >>> >> > >> >>> >> Matthew McCormick (8): > >> >>> >> COMP: Do not use C++11 alignas in itkAlignedTypedef. > >> >>> >> COMP: Remove unused argument in ConditionVariableNoThreads. > >> >>> >> DOC: Correct spelling of Continuous. > >> >>> >> COMP: Fix KernelTransform SetFixedParameters argument type. > >> >>> >> STYLE: Use prefix increment operator in ImageBase. > >> >>> >> COMP: Use ITK's pygccxml by correctly setting up the > sys.path > >> >>> >> COMP: Set CMP0054 to new. > >> >>> >> > >> >>> >> Michka Popoff (1): > >> >>> >> COMP: Disable incompatible modules when using Python 3 > >> >>> >> wrapping > >> >>> >> > >> >>> >> Mikhail Isakov (1): > >> >>> >> BUG: DiffusionTensor3DReconstruction segfault if no baseline > >> >>> >> image > >> >>> >> _______________________________________________ > >> >>> >> Powered by www.kitware.com > >> >>> >> > >> >>> >> Visit other Kitware open-source projects at > >> >>> >> http://www.kitware.com/opensource/opensource.html > >> >>> >> > >> >>> >> Kitware offers ITK Training Courses, for more information visit: > >> >>> >> http://kitware.com/products/protraining.php > >> >>> >> > >> >>> >> Please keep messages on-topic and check the ITK FAQ at: > >> >>> >> http://www.itk.org/Wiki/ITK_FAQ > >> >>> >> > >> >>> >> Follow this link to subscribe/unsubscribe: > >> >>> >> http://public.kitware.com/mailman/listinfo/insight-developers > >> >>> > > >> >>> _______________________________________________ > >> >>> Powered by www.kitware.com > >> >>> > >> >>> Visit other Kitware open-source projects at > >> >>> http://www.kitware.com/opensource/opensource.html > >> >>> > >> >>> Kitware offers ITK Training Courses, for more information visit: > >> >>> http://kitware.com/products/protraining.php > >> >>> > >> >>> Please keep messages on-topic and check the ITK FAQ at: > >> >>> http://www.itk.org/Wiki/ITK_FAQ > >> >>> > >> >>> Follow this link to subscribe/unsubscribe: > >> >>> http://public.kitware.com/mailman/listinfo/insight-developers > >> >> > >> >> > >> >> _______________________________________________ > >> >> Powered by www.kitware.com > >> >> > >> >> Visit other Kitware open-source projects at > >> >> http://www.kitware.com/opensource/opensource.html > >> >> > >> >> Kitware offers ITK Training Courses, for more information visit: > >> >> http://kitware.com/products/protraining.php > >> >> > >> >> Please keep messages on-topic and check the ITK FAQ at: > >> >> http://www.itk.org/Wiki/ITK_FAQ > >> >> > >> >> Follow this link to subscribe/unsubscribe: > >> >> http://public.kitware.com/mailman/listinfo/insight-developers > >> >> > >> >> _______________________________________________ > >> >> Community mailing list > >> >> commun...@itk.org > >> >> http://public.kitware.com/mailman/listinfo/community > >> >> > >> > >
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
