Nice! Thank you for your contribution.

There is already a patch out for the HDF5 issue here: 
http://review.source.kitware.com/#/c/21231/

You could checkout that patch out, test it and review it, to ensure it 
addresses your issue.

Thanks,
Brad


On Jun 17, 2016, at 5:21 AM, Pierre Barbier de Reuille 
<pierre.barbierdereui...@gmail.com<mailto:pierre.barbierdereui...@gmail.com>> 
wrote:

Hello,

sorry for the delay, but it took a while to test everything correctly. So I 
created a topic called fix_fftwf_used_with_fftwd and made the modification.
I tested it with the FFTW compiled by ITK itself and all FFTW-related tests 
passed without problem. There are some tests failing, but they are unrelated to 
the modification. For completeness, here is the list of tests that failed:

The following tests FAILED:
         79 - vnl_algo_test_convolve (Failed)
        824 - itkHDF5ImageIOTest (Failed)
        825 - itkHDF5ImageIOStreamingReadWriteTest (Failed)
        1177 - itkCastImageFilterTest (Failed)

Cheers,

Pierre

On Wed, 15 Jun 2016 at 20:35 Bradley Lowekamp 
<blowek...@mail.nih.gov<mailto:blowek...@mail.nih.gov>> wrote:
Hello,

Looks like you found a bug!

Can you please test the change and submit a patch for review?
https://itk.org/Wiki/ITK/Git/Develop

Thanks,
Brad

On Jun 15, 2016, at 9:36 AM, Pierre Barbier de Reuille 
<pierre.barbierdereui...@gmail.com<mailto:pierre.barbierdereui...@gmail.com>> 
wrote:

Hey,

I just compiled the latest version of ITK (4.10.0) with MinGW under windows and 
I had a problem.

I compiled it with FFTW compiled with double precision, but in the file 
Module/Filtering/FFT/src/itkFFTWGlobalConfiguration.cxx the function 
fftwf_import_wisdom_from_file is used twice when fftw_import_wisdom_from_file 
should be used: on lines 632 and 709.

Otherwise, everything compiled just fine.

Cheers,

Pierre

--

Dr. Barbier de Reuille, Pierre
Institute of Plant Sciences
University of Bern
Altenbergrain 21, CH-3013 Bern, Switzerland

_______________________________________________
Powered by www.kitware.com<http://www.kitware.com/>

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers

--

Dr. Barbier de Reuille, Pierre
Institute of Plant Sciences
University of Bern
Altenbergrain 21, CH-3013 Bern, Switzerland

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers

Reply via email to