Hi Celina, The patch for this is here:
http://review.source.kitware.com/#/c/23300/ - M On Wed, Mar 28, 2018 at 9:35 AM, Celina Imielinska < celina_imielin...@yahoo.com> wrote: > Matt, > > do you plan to correct the actual document? > > https://itk.org/ItkSoftwareGuide.pdf > > In the text, in the section 4.1.4, pages 41 and 42 : > "A pixel is considered to be the rectangular region surrounding the pixel > center holding the data value. This can be viewed as the *Voronoi region > of the image grid,* as illustrated in the right side of the figure. > Linear interpolation of image values is performed inside the* Delaunay > region whose corners are pixel centers*." > > these statements "Voronoi region of the image grid" and "Delaunay region > whose corners are pixed centers" - should go. > > the image 4.1 "Geometrical concepts associated with the ITK image", > should be redone too. In the image "Linear Interpolation Region Delaunay > Region" and "Pixel Coverage Voronoi Region" must be replaced, > > This document is used and shared by many and should not include confusing > terminology. > > Thanks again, > > Celina > ------------------------------ > *From:* Celina Imielinska <celina_imielin...@yahoo.com> > *To:* Matt McCormick <matt.mccorm...@kitware.com> > *Sent:* Wednesday, March 28, 2018 9:21 AM > > *Subject:* Re: [ITK-dev] ITK Software Guide > > Matt, > > thank you for the correction, > > Celina > > ------------------------------ > *From:* Matt McCormick <matt.mccorm...@kitware.com> > *To:* Celina Imielinska <celina_imielin...@yahoo.com> > *Cc:* Stephen Aylward <stephen.aylw...@kitware.com>; Bradley Lowekamp < > blowek...@mail.nih.gov>; Insight Developers <Insight-developers@itk.org>; > Luis Ibanez <luis.iba...@gmail.com> > *Sent:* Tuesday, March 27, 2018 5:23 PM > *Subject:* Re: [ITK-dev] ITK Software Guide > > Thank you for efforts to improve the work, Celina. The ITK Software Guide > is a living document, and many students should continue to learn from the > body of knowledge that Luis poured out many years ago. > > > Here is a patch for the figure: > > https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/pull/65 > > and the text: > > http://review.source.kitware.com/#/c/23300/ > > > Thanks, > Matt > > On Tue, Mar 27, 2018 at 4:19 PM, Celina Imielinska < > celina_imielin...@yahoo.com> wrote: > > That would be appropriate > > Thank you! > ------------------------------ -------------- > On Tue, 3/27/18, Matt McCormick <matt.mccorm...@kitware.com> wrote: > > Subject: Re: [ITK-dev] ITK Software Guide > To: "Celina Imielinska" <celina_imielin...@yahoo.com> > Cc: "Stephen Aylward" <stephen.aylw...@kitware.com>, "Bradley Lowekamp" < > blowek...@mail.nih.gov>, "Insight Developers" <Insight-developers@itk.org>, > "Luis Ibanez" <luis.iba...@gmail.com> > Date: Tuesday, March 27, 2018, 2:45 PM > > Ah, I see > now, Celina. Thanks for sharing the screenshots. > How about removing the mention of > Voronoi region and Delaunay region from that location in the > text and changing the annotation in the text to "Pixel > Centered Region" and "Pixel-Corner Centered > Region"? > - > M > On Tue, Mar 27, 2018 at > 2:22 PM, Celina Imielinska <celina_imielin...@yahoo.com> > wrote: > in > the attached document > page > 41in > section4.1.4 > Defining Origin and Spacing > > > > From: Matt McCormick > <matt.mccorm...@kitware.com> > To: Celina Imielinska > <celina_imielin...@yahoo.com> > > Cc: Stephen Aylward > <stephen.aylw...@kitware.com>; > Bradley Lowekamp <blowek...@mail.nih.gov>; > Insight Developers <Insight-developers@itk.org>; > Luis Ibanez <luis.iba...@kitware.com> > Sent: Tuesday, March > 27, 2018 2:09 PM > Subject: Re: [ITK-dev] > ITK Software Guide > > > Hi Celina, > I only > see "Voronoi region" mentioned once > here: > https://github.com/ > InsightSoftwareConsortium/ ITKSoftwareGuide/blob/ > 7eb1f6dda1e5bfe57938f53584113e e771b298a7/SoftwareGuide/ > Latex/DesignAndFunctionality/ > HybridSegmentationMethods.tex > Perhaps we just replace > "Voronoi region" with > "region"? > > Other > improvements to make the language more accurate / precise > are welcome. > > Thanks,Matt > > > On > Tue, Mar 27, 2018 at 1:59 PM, Celina Imielinska < > celina_imielin...@yahoo.com> > wrote: > > Hello Matt, > thank > you for your email... > I > agree it - but this one of the fundamendat geometric > constructs used in the Guide - that is just > ill-named... > How > can we name it differently.... definitely, not as Voronoi > region, nor Delaunay region (completely wrong) > -let > us discuss, > Best, > Celina > From: Matt > McCormick <matt.mccorm...@kitware.com> > To: Celina Imielinska > <celina_imielin...@yahoo.com> > > Cc: Stephen Aylward > <stephen.aylw...@kitware.com>; > Bradley Lowekamp <blowek...@mail.nih.gov>; > Insight Developers <Insight-developers@itk.org>; > Luis Ibanez <luis.iba...@kitware.com> > Sent: Tuesday, March > 27, 2018 1:48 PM > Subject: Re: [ITK-dev] > ITK Software Guide > > > > Hi Celina, > Improvements to the Software Guide > are welcome. Please see the README here on how to > contribute: > https://github.com/ > InsightSoftwareConsortium/ > ITKSoftwareGuide > Thanks,Matt > On > Tue, Mar 27, 2018 at 1:42 PM, Celina Imielinska via > Insight-developers <insight-developers@itk.org> > wrote: > > Dear > All > (I > have emailed separately Bill Schroeder at Kitware) > I > am very happy that ITK Toolkit has been thriving over so > many years. Kitware has done amazing job to maintain it and > to expand it. > Still, > I am trying to contact the main co-authors of the currect > ITK Software Guide. > I > am writing about the usage of "Voronoi Region" > terminology in the recent editions of the ITK Software guide > - that is very odd and not in agreement with how Voronoi > Diagram, that is one of the fundamental geometric > structures, is defined:https://www.cs.ucsb. edu/~suri/ > <https://www.cs.ucsb.edu/~suri/> > cs235/Voronoi.pdf > > Could > you please email me - I would like to suggest that if we > want to use as "geometrical concepts associated with > the ITK image" "Voronoi region" in a form > what I consider a degenerative representation of it - then > maybe it would be wise to name it differently. Not to > mention the usage of another oddity: Delaunay Region - > what is it? Voronoi Diagram and its dual, Delaunay > Triangulation are classic geometric constructs that require > that the points, in the Voronoi diagram, the Voronoi points, > satisfy: > "Non-degeneracy > Condition: Assume no 4 cocircular points, and no 3 > collinear." > This > is violated in the construct included in the Guide and > referred to as Voronoi Region and Delaunay Region. > I > don't mind that the guide is not including any more my > original hybrid segmentation contribution that included > Voronoi Diagram classification https://core. ac.uk/download/ > <https://core.ac.uk/download/> > pdf/27299860.pdfI > woudl like to ask you to discuss what can be done with > possibly correctingthe odd terminology, > looking > forward to hear from > Best > Regards, > Celina > Imielinska > Celina > Imielinska, PhDPrincipalVesalius > Technologies LLCPrinceton > NJcelina_imielinska@yahoo. com609 240 4721 > PS. > old version http://www.sci.utah. > edu/publications/ibanez03/ > ItkSoftwareGuide.pdf > newest https://itk.org/ > ItkSoftwareGuide.pdf > The ITK community is transitioning from this > mailing list to discourse.itk.org. > Please join us there! > > ______________________________ ________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/ > opensource/opensource.html > > > > Kitware offers ITK Training Courses, for more information > visit: > > http://kitware.com/products/ > protraining.php > > > > Please keep messages on-topic and check the ITK FAQ at: > > http://www.itk.org/Wiki/ITK_ > FAQ > > > > Follow this link to subscribe/unsubscribe: > > https://itk.org/mailman/ > listinfo/insight-developers > > > > > > > > > > > > > > > > > >
The ITK community is transitioning from this mailing list to discourse.itk.org. Please join us there! ______________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: https://itk.org/mailman/listinfo/insight-developers
