Yes. All the specs are passing now. Upgrading to specs did bring up some errors, which also needed resolving.
Take care, Andrei On Fri, Feb 6, 2009 at 1:54 PM, Joaquin Rivera Padron <[email protected]>wrote: > thanks Andrei > the change @buffer to buffer did the trick. I've pushed it to github > > regarding FckEditor specs as I said I'm not using those at the moment, so > I'll leave resolution for others. But have you solved those in your branch? > > cheers > joaquin > > 2009/2/5 Andrei Erdoss <[email protected]> > >> Hello, >> >> I also just upgraded insoshi to Rails 2.2.2 at: >> http://github.com/cauta/insoshi/tree/master >> >> Regarding some of the spec errors in the gist, the ones relating to >> relative_url_root have to do with plugin Fckeditor. >> >> In BufferedLogger, change @buffer to buffer. >> >> If you have any questions, please let me know. >> >> Thanks, >> >> >> On Wed, Feb 4, 2009 at 7:58 PM, Joaquin Rivera Padron <[email protected] >> > wrote: >> >>> hi there, >>> I have ported my insoshi project to rails 2.2.2, and the whole process >>> was very pleasant. My last rebase from michael hartl was >>> c596d8ecbdb9e8bdad2e87ad74c950ff201ef489. I am glad to say that my itch >>> is scratched until happiness. >>> >>> The problems arose when trying to make that happiness available to all of >>> you. The thing is I keep having some view specs to fail for some >>> funcionality I dont need (which reminds me of another questions, but those >>> for another email). The failing specs are here: >>> http://gist.github.com/58231 >>> >>> I have pushed the results of the ongoing migration to: >>> >>> http://github.com/joahking/insoshi/tree/migrating_to_rails_2_2_2 >>> >>> If you are interested and/or you are one who knows about those specs in >>> gist, there is really not much to do to make insoshi fully into rails2.2.2. >>> But maybe there's someone who knows better >>> >>> The whole thing about migrating was about minimal changes: >>> >>> baa55c8b531a30a29093e8a14f94c10afb23f8d4 make person_mailer.rb specs pass >>> :100644 100644 c80d16d... c5b76bc... M app/models/person_mailer.rb >>> >>> b5eaa43f03b5e6cf0aa4b1544ac9a9f3ef593950 removed unneeded CSRF_fix.rb, >>> solved DEPRECATION WARNING: unverifiable_types >>> :100644 000000 b77aea6... 0000000... D config/initializers/CSRF_fix.rb >>> >>> df4e4534fd7d55fd67c07533d88ddc09fc0e8ec3 solved truncate Deprecation >>> Warning >>> :100644 100644 02b6c2a... 8bebaa7... M app/views/people/_person.html.erb >>> >>> e55c1bcda1fffadc1aa0ca49cfd564183e58d2a2 solved concat Deprecation >>> Warning >>> :100644 100644 4141d6a... dc9c966... M app/helpers/application_helper.rb >>> >>> 9b91158b2a71cb32c68bb69d31066d4328f4727d changes to environment.rb for >>> rails 2.2.2 >>> :100644 100644 d0b37b9... c2f1cb1... M config/environment.rb >>> >>> in config/environment.rb right now I commented the additions to the >>> class BufferedLogger of ActiveSupport. But I guess it wont be difficult to >>> achieve to those in need of that. >>> >>> I tried to clean everything of my project you dont need, but if some >>> remains are disturbing you, feel free to ask >>> >>> hth somebody, >>> joaquin >>> >>> >> >> >> -- >> Andrei Erdoss >> >> >> > > > -- > www.least-significant-bit.com > > > > > -- Andrei Erdoss --~--~---------~--~----~------------~-------~--~----~ Insoshi developer site: http://dogfood.insoshi.com/ Insoshi documentation: http://docs.insoshi.com/ You received this message because you are subscribed to the Google Groups "Insoshi" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/insoshi?hl=en -~----------~----~----~----~------~----~------~--~---
