On Fri, 2006-04-07 at 19:17, Rich McAllister wrote: > Peter Tribble wrote: > > Hi, > > > > There's an undocumented feature in pkgchk, as reported > > in bug 4762083, > > Filed by me; I was careful to call it "undocumented behavior" because > it's not at all clear it's a feature. > > > My own view would be to remove > > it, as it's undocumented, doesn't work right, and > > overlaps with functionality provided by the -P > > option (which wasn't present at the time the bug > > was filed). Removing it also helps (possibly > > significantly) performance, and makes the code > > simpler. > > I can't see it changing performance much;
Hm. Old version: ptime pkgchk -l -p /usr/bin/ls real 0.662 user 0.557 sys 0.104 Dropping the requirement to support wildcards allows a different algorithm, so we get: ptime ./pkgchk -l -p /usr/bin/ls real 0.007 user 0.002 sys 0.004 Of course, there's a lot more to do (solve the SEGVs I keep getting for starters). -- -Peter Tribble L.I.S., University of Hertfordshire - http://www.herts.ac.uk/ http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/
