You don't need to update the copyright on the header file that is only moving from one place to another.
Otherwise, this looks good. Thanks. --Mark > Mark, > > When we spoke earlier this week, you mentioned that I should think about > moving instzones_api.h out of usr/src/lib/libinstzones/common in order > to guarantee that builds will always include the header from the proto > area instead of from common. > > I moved instzones_api.h into a separate directory and updated HDRDIR > accordingly. I have updated the webrev: > http://cr.opensolaris.org/~mwaterl/bf6872091/ > > Please sign off if you are okay with the fix. > > thanks, > Moriah > > Moriah Waterland wrote: >> Hi Mark, >> >> I messed up and forgot to cc install-discuss when I sent you my original >> code review request. I am resending you the code review request with a >> cc to the alias. I have also included answers to your questions. >> >> This is a simple fix that is needed for building the slim_source gate. >> When I moved the SVr4 packaging code to ON (6739234 move SVR4 packaging >> to ONNV gate) I made a mistake and didn't realize that the >> instzones_api.h was also required to build the slim_source gate. >> Currently there is still a copy of libinstzones in slim_source and I >> need to complete this fix to SUNWinstallint before I can clean up the >> slim_source gate. >> >> Code review: >> http://cr.opensolaris.org/~mwaterl/bf6872091/ >> >> Bug info: >> 6872091 Need to deliver instzones_api.h in SUNWinstallint >> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6872091 >> >> Mark J. Nelson wrote: >>> Should any ON files including this header be changed to use <> instead >>> of "" quoting? >> The only ON files that use "" for including instzones_api.h are located >> in the same directory as this header file. I don't think that I need to >> make any changes to those files. >> >>> How do the slim source files currently find this? >> The slim source files currently include the copy of instzones_api.h that >> still lives in the slim_source gate. I will be pulling libinstzones >> along with this header from slim_source after I putback this change. >> >> thanks, >> Moriah >> _______________________________________________ >> install-discuss mailing list >> install-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/install-discuss > _______________________________________________ > install-discuss mailing list > install-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/install-discuss
