Sure Moriah, Your plan to handle this is fine with me.
Joe Moriah Waterland wrote: > Joe, > > I am sorry for not having asked for this in my last email, but I would > really appreciate it if you could reply explicitly saying whether or > not you are okay with what I am doing here. > > thanks, > Moriah > > Moriah Waterland wrote: >> Joe, >> >> Thank you for the feedback. First, I want to apologize for not having >> clearly articulated the context behind this code review. >> >> This code move should have been part of the project to move the SVR4 >> packaging code to ON from the Legacy Install consolidation, but I made a >> mistake and forgot to check in other packages for SVr4 related >> deliveries. Liane noticed that this script was still imported into ON >> from a package over in the Legacy Install gate when she was working on >> the ON OpenSolaris transition. >> >> The only goal of this fix was to move the code. Yes, I know that this >> means that problems are just moving from one place to another but these >> issues must be dealt with separately. I will file an RFE to clean up the >> things you mentioned about the script. >> >> Regarding your question about the copyright. This file was missing >> copyright information so I did add that to the i.preserve script. >> Because this file has not been modified since it was originally putback >> in 1998, I used that copyright date. >> >> Please let me know if you have further questions. >> >> >> thanks, >> Moriah >> >> >> Joseph J VLcek wrote: >>> Moriah Waterland wrote: >>>> I think that what you saw was just cr.opensolaris.org being flaky. >>>> Seems >>>> to work fine now. >>>> >>>> thanks, >>>> -Moriah >>>> >>>> Joseph J VLcek wrote: >>>>> Moriah Waterland wrote: >>>>>> Dave, >>>>>> >>>>>> I am moving the packaging install script i.preserve as well as >>>>>> i.CONFIG.prsv (which is a link to i.preserve) from the Legacy >>>>>> Install >>>>>> gate over to ON. These files were delivered from SUNWswmt (which >>>>>> primarily delivers the legacy patch tools) but i.preserve and >>>>>> i.CONF.prsv need to move to SUNWpkgcmdsu where the other install >>>>>> scripts >>>>>> are delivered from. >>>>>> >>>>>> The only changes I made to the i.preserve script was to add >>>>>> copyright >>>>>> information to the file. >>>>>> >>>>>> Webrev: >>>>>> http://monaco.sfbay.sun.com/detail.jsf?cr=6873067 >>>>>> >>>>>> Bug info: >>>>>> http://cr.opensolaris.org/~mwaterl/bf6873067/ >>>>>> 6873067 i.perserve and i.CONFIG.prsv need to be moved to ON >>>>>> >>>>>> thanks, >>>>>> Moriah >>>>>> >>>>>> _______________________________________________ >>>>>> install-discuss mailing list >>>>>> install-discuss at opensolaris.org >>>>>> http://mail.opensolaris.org/mailman/listinfo/install-discuss >>>>> >>>>> Moriah, >>>>> >>>>> The URL you have list for the webrev is incorrect. >>>>> >>>>> Joe >>> >>> >>> usr/src/cmd/svr4pkg/pkgscripts/i.preserve.sh >>> >>> - Copyright is 1998 >>> >>> - Instead of no and yes you can use the built in true and false >>> >>> - you should use print and printf in place of echo >>> >>> See: >>> http://installzone-wiki.central.sun.com/wiki/index.php/Ksh93_Tips#use_true_and_false_ksh93_builtins >>> >>> >>> >>> Hope this helps. >>> Joe >> _______________________________________________ >> install-discuss mailing list >> install-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/install-discuss
