Dear Authors,

thanks forwriting this document, which is quite clear.
As a shepherd I went through the document and have a few comments.


I think the the definition of _unique_ Node ID is a bit hidden in the document 
and not clearly spelled out.
The second paragraph of the abstract is close but not perfect.

My understanding is the following:

The _combination_ of IP Address and Name sub-objects MUST be unique.
If the IP Address sub-object is NOT included, then the Name sub-object MUST be 
unique.
Vice versa, if the Name sub-object is NOT included, then the IP Address 
sub-object MUST be unique.

Is my understanding correct? 
Further, _uniqueness_ is relative to the local domain?  Or a different scope? 

Can text be added somewhere in the document to clearly define the above?


Some additional comments in the following.



Last paragraph of Section 3.1 states:
> 
>  It is valid (though pointless until additional bits are assigned by
>    IANA) to receive a Node Identification Object where bits 5 and 6 are
>    both 0; this MUST NOT generate a warning or error.

The paragraph does not say what to do with the object. MUST Ignore if all bits 
are 0? 



In Section 3.3, the encoding of the name is unclear to me. 
The field is max 64 octets  but can contain only the first 63 octets of the 
hostname, which means that the last octet is the NULL character, right?
However, the following sentence (in the same section) 

> The node name MUST be padded with ASCII
>    NUL characters if the object would not otherwise terminate on a
>    4-octet boundary.

Seems to suggest that if the name terminates at a 4-octet boundary the NULL 
character is not necessary.
I would suggest make the NULL character termination mandatory in any case. 
Having corner cases makes implementations more complex and less reliable.



For the IANA Considerations Section: Officially this document is the one asking 
to allocate the type codepoint 5 for the object, hence would be good to have 
the table that reflects the entry in the IANA database, not just stating “IANA 
gave us value 5….”.

BTW the start of the first paragraph is weird: “This IANA has allocated….”   


As a final note, would be great to have all the tables and figures available in 
SVG.


Thanks

Luigi


_______________________________________________
Int-area mailing list -- int-area@ietf.org
To unsubscribe send an email to int-area-le...@ietf.org

Reply via email to