On Thu, 15 Apr 2010 09:08:16 +0200, Daniel Vetter <[email protected]> wrote: > Current code is definitely crap: Largest pitch allowed spills into > the TILING_Y bit of the fence registers ... :( > > I've rewritten the limits check under the assumption that 3rd gen hw > has a 3d pitch limit of 8kb (like 2nd gen). This is supported by an > otherwise totally misleading XXX comment. > > This bug mostly resulted in tiling-corrupted pixmaps because the kernel > allowed too wide buffers to be tiled. Bug brought to the light by the > xf86-video-intel 2.11 release because that unconditionally enabled > tiling for pixmaps, relying on the kernel to check things. Tiling for > the framebuffer was not affected because the ddx does some additional > checks there ensure the buffer is within hw-limits. > > Signed-off-by: Daniel Vetter <[email protected]> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=27449 > Tested-by: Alexander Lam <[email protected]> > Cc: [email protected]
Could we please just test against 8192 bytes intead of these obfuscated values? Nice fix, though :)
pgpdKFB6tX5J8.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
