Since "Dynamic page table allocations" were introduced, our page tables
can grow (being dynamically allocated) with address space range usage.
Unfortunately, their lifetime is bound to vm. This is not a huge problem
when we're not using softpin - drm_mm is creating an upper bound on used
range by causing addresses for our VMAs to eventually be reused.

With softpin, long lived contexts can drain the system out of memory
even with a single "small" object. For example:

bo = bo_alloc(size);
while(true)
    offset += size;
    exec(bo, offset);

Will cause us to create new allocations until all memory in the system
is used for tracking GPU pages (even though almost all PTEs in this vm
are pointing to scratch).

Let's free unused page tables in clear_range to prevent this - if no
entries are used, we can safely free it and return this information to
the caller (so that higher-level entry is pointing to scratch).

v2: Document return value and free semantics (Joonas)
v3: No newlines in vars block (Joonas)

Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Michel Thierry <michel.thie...@intel.com>
Cc: Mika Kuoppala <mika.kuopp...@intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 84 +++++++++++++++++++++++++++++++++----
 1 file changed, 76 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index c284d8d..e733657 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -704,13 +704,14 @@ static int gen8_48b_mm_switch(struct i915_hw_ppgtt *ppgtt,
        return gen8_write_pdp(req, 0, px_dma(&ppgtt->pml4));
 }
 
-static void gen8_ppgtt_clear_pt(struct i915_address_space *vm,
+/* Removes entries from a single page table, releasing it if it's empty.
+ * Caller can use the return value to update higher-level entries */
+static bool gen8_ppgtt_clear_pt(struct i915_address_space *vm,
                                struct i915_page_table *pt,
                                uint64_t start,
                                uint64_t length)
 {
        struct i915_hw_ppgtt *ppgtt = i915_vm_to_ppgtt(vm);
-
        unsigned int pte_start = gen8_pte_index(start);
        unsigned int num_entries = gen8_pte_count(start, length);
        uint64_t pte;
@@ -719,63 +720,130 @@ static void gen8_ppgtt_clear_pt(struct 
i915_address_space *vm,
                                                 I915_CACHE_LLC);
 
        if (WARN_ON(!px_page(pt)))
-               return;
+               return false;
 
        bitmap_clear(pt->used_ptes, pte_start, num_entries);
 
+       if (bitmap_empty(pt->used_ptes, GEN8_PTES)) {
+               free_pt(vm->dev, pt);
+               return true;
+       }
+
        pt_vaddr = kmap_px(pt);
 
        for (pte = pte_start; pte < num_entries; pte++)
                pt_vaddr[pte] = scratch_pte;
 
        kunmap_px(ppgtt, pt_vaddr);
+
+       return false;
 }
 
-static void gen8_ppgtt_clear_pd(struct i915_address_space *vm,
+/* Removes entries from a single page dir, releasing it if it's empty.
+ * Caller can use the return value to update higher-level entries
+ */
+static bool gen8_ppgtt_clear_pd(struct i915_address_space *vm,
                                struct i915_page_directory *pd,
                                uint64_t start,
                                uint64_t length)
 {
+       struct i915_hw_ppgtt *ppgtt = i915_vm_to_ppgtt(vm);
        struct i915_page_table *pt;
        uint64_t pde;
+       gen8_pde_t *pde_vaddr;
+       gen8_pde_t scratch_pde = gen8_pde_encode(px_dma(vm->scratch_pt),
+                                                I915_CACHE_LLC);
+       bool reduce;
 
        gen8_for_each_pde(pt, pd, start, length, pde) {
                if (WARN_ON(!pd->page_table[pde]))
                        break;
 
-               gen8_ppgtt_clear_pt(vm, pt, start, length);
+               reduce = gen8_ppgtt_clear_pt(vm, pt, start, length);
+
+               if (reduce) {
+                       __clear_bit(pde, pd->used_pdes);
+                       pde_vaddr = kmap_px(pd);
+                       pde_vaddr[pde] = scratch_pde;
+                       kunmap_px(ppgtt, pde_vaddr);
+               }
+       }
+
+       if (bitmap_empty(pd->used_pdes, I915_PDES)) {
+               free_pd(vm->dev, pd);
+               return true;
        }
+
+       return false;
 }
 
-static void gen8_ppgtt_clear_pdp(struct i915_address_space *vm,
+/* Removes entries from a single page dir pointer, releasing it if it's empty.
+ * Caller can use the return value to update higher-level entries
+ */
+static bool gen8_ppgtt_clear_pdp(struct i915_address_space *vm,
                                 struct i915_page_directory_pointer *pdp,
                                 uint64_t start,
                                 uint64_t length)
 {
+       struct i915_hw_ppgtt *ppgtt = i915_vm_to_ppgtt(vm);
        struct i915_page_directory *pd;
        uint64_t pdpe;
+       gen8_ppgtt_pdpe_t *pdpe_vaddr;
+       gen8_ppgtt_pdpe_t scratch_pdpe =
+               gen8_pdpe_encode(px_dma(vm->scratch_pd), I915_CACHE_LLC);
+       bool reduce;
 
        gen8_for_each_pdpe(pd, pdp, start, length, pdpe) {
                if (WARN_ON(!pdp->page_directory[pdpe]))
                        break;
 
-               gen8_ppgtt_clear_pd(vm, pd, start, length);
+               reduce = gen8_ppgtt_clear_pd(vm, pd, start, length);
+
+               if (reduce) {
+                       __clear_bit(pdpe, pdp->used_pdpes);
+                       pdpe_vaddr = kmap_px(pdp);
+                       pdpe_vaddr[pdpe] = scratch_pdpe;
+                       kunmap_px(ppgtt, pdpe_vaddr);
+               }
+       }
+
+       if (bitmap_empty(pdp->used_pdpes, I915_PDPES_PER_PDP(vm->dev))) {
+               free_pdp(vm->dev, pdp);
+               return true;
        }
+
+       return false;
 }
 
+/* Removes entries from a single pml4.
+ * This is the top-level structure in 4-level page tables used on gen8+.
+ * Empty entries are always scratch pml4e.
+ */
 static void gen8_ppgtt_clear_pml4(struct i915_address_space *vm,
                                  struct i915_pml4 *pml4,
                                  uint64_t start,
                                  uint64_t length)
 {
+       struct i915_hw_ppgtt *ppgtt = i915_vm_to_ppgtt(vm);
        struct i915_page_directory_pointer *pdp;
        uint64_t pml4e;
+       gen8_ppgtt_pml4e_t *pml4e_vaddr;
+       gen8_ppgtt_pml4e_t scratch_pml4e =
+               gen8_pml4e_encode(px_dma(vm->scratch_pdp), I915_CACHE_LLC);
+       bool reduce;
 
        gen8_for_each_pml4e(pdp, pml4, start, length, pml4e) {
                if (WARN_ON(!pml4->pdps[pml4e]))
                        break;
 
-               gen8_ppgtt_clear_pdp(vm, pdp, start, length);
+               reduce = gen8_ppgtt_clear_pdp(vm, pdp, start, length);
+
+               if (reduce) {
+                       __clear_bit(pml4e, pml4->used_pml4es);
+                       pml4e_vaddr = kmap_px(pml4);
+                       pml4e_vaddr[pml4e] = scratch_pml4e;
+                       kunmap_px(ppgtt, pml4e_vaddr);
+               }
        }
 }
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to