Arg... I don't know how this happened.
I thought we agreed upon using strlcpy()?

On 08/02/18 10:09, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function 
‘i915_perf_load_test_config_cflgt3’:
drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated 
before terminating nul copying 36 bytes from a string of the same length 
[-Werror=stringop-truncation]

Fixes: 4407eaa9b0cc ("drm/i915/perf: add support for Coffeelake GT3")
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwer...@intel.com>
Cc: Matthew Auld <matthew.a...@intel.com>
---
  drivers/gpu/drm/i915/i915_oa_cflgt3.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_oa_cflgt3.c 
b/drivers/gpu/drm/i915/i915_oa_cflgt3.c
index 42ff06fe54a3..b3abc90b6864 100644
--- a/drivers/gpu/drm/i915/i915_oa_cflgt3.c
+++ b/drivers/gpu/drm/i915/i915_oa_cflgt3.c
@@ -86,7 +86,7 @@ i915_perf_load_test_config_cflgt3(struct drm_i915_private 
*dev_priv)
  {
        strncpy(dev_priv->perf.oa.test_config.uuid,
                "577e8e2c-3fa0-4875-8743-3538d585e3b0",
-               UUID_STRING_LEN);
+               sizeof(dev_priv->perf.oa.test_config.uuid));
        dev_priv->perf.oa.test_config.id = 1;
dev_priv->perf.oa.test_config.mux_regs = mux_config_test_oa;


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to