>-----Original Message-----
>From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
>Sent: Tuesday, April 10, 2018 3:57 PM
>To: Shi, Yang A <yang.a....@intel.com>; Chris Wilson 
>Cc: He, Bo <bo...@intel.com>
>Subject: RE: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component 
>before audio driver use it
>On Tue, 10 Apr 2018, "Shi, Yang A" <yang.a....@intel.com> wrote:
>> issue: snd_soc_skl meet "failed to add i915 component master (-19)"
>> when platform don't connect any display output.
>> i915 do initialization before than skl_probe, but if there is no
>> display output connect, in function drm_dp_dpcd_access, there is a 32
>> retry for aux i2c transactions. It will meet timeout and do usleep.
>> Then skl_probe function will be scheduled. It will call
>> snd_hdac_i915_init, and it will meet "failed to add i915 component
>> master" error.  And whole snd_soc_skl initialization will be failed,
>> audio can't work normally anymore.
>> So i915 driver need to move intel_audio_init at the beginning of
>> intel_modeset_init. This will make sure i915_audio_component_init
>> process before snd_hdac_i915_init call it.
>We do intel_audio_init() and register the audio component when we are ready to 
>the audio component calls. We are ready at i915_driver_register(). We are not 
>ready at

Thanks to comments my patch.
After I check the whole driver code, I think all ops in 
i915_audio_component_ops should be ready 
at the beginning of function intel_modeset_init. So can we move 
intel_audio_init as early as we can.

Would you like to suggest a better place to do intel_audio_init?



>Jani Nikula, Intel Open Source Technology Center
Intel-gfx mailing list

Reply via email to