On 6/13/2018 11:10 PM, Dhinakaran Pandiyan wrote:
On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote:
On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote:
On Wed, 13 Jun 2018, "Nagaraju, Vathsala" <vathsala.nagaraju@intel.
m> wrote:

On 6/12/2018 2:30 PM, Jani Nikula wrote:

On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju@intel
om> wrote:

From: Vathsala Nagaraju <vathsala.nagar...@intel.com>

Adds new psrwake options defined in the below table.
Platform        PSR wake options vbt version
SKL             All PV releases (Check for 203+ might help
but cannot be foolproof)
BXT             Uses old interpretation.
CNL/ICL+        All
GLK             All

For SKL, we will continue to use older interpretation for the
above reason.

Cc: Jani Nikula <jani.nik...@intel.com>
Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
Cc: Puthikorn Voravootivat <put...@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagar...@intel.com
   drivers/gpu/drm/i915/intel_bios.c | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..010ff68 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int
drm_i915_private *dev_priv,
         * New psr options 0=500us, 1=100us, 2=2500us,
         * Old decimal value is wake up time in multiples
100 us.
-       if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+       if ((INTEL_GEN(dev_priv) >= 10) ||
+           (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))
Please keep the version check.
Sure. For SKL , shall we use older interpretation for all bdb
version as
vbt team cannot confirm bdb version for SKL?
I guess.

Why not change the version check to >= 203, if that's what PV
had as per your commit message? With the current code, Linux and
Windows set 500 us and 2.5 ms respectively on my laptop.
Said laptop is a SKL with bdb version 205.
+ ashutosh(VBT team)
Since VBT team cannot confirm version for SKL ,so skipped for skylake.
I did a copy paste of the table provided by vbt team, will edit for skylake.

Intel-gfx mailing list

Reply via email to