On Mon, 24 Mar 2025, Nicolas Chauvet <kwiz...@gmail.com> wrote:
> Le lun. 24 mars 2025 à 10:34, Jani Nikula
> <jani.nik...@linux.intel.com> a écrit :
>>
>> On Mon, 24 Mar 2025, Jani Nikula <jani.nik...@linux.intel.com> wrote:
>> > On Mon, 24 Mar 2025, Nicolas Chauvet <kwiz...@gmail.com> wrote:
>> >> Enlarge the signature field to accept the string termination.
>> >>
>> >> Cc: sta...@vger.kernel.org
>> >> Fixes: 93615d59912 ("Revert drm/i915/gvt: Fix out-of-bounds buffer write
>> >> into opregion->signature[]")
>> >> Signed-off-by: Nicolas Chauvet <kwiz...@gmail.com>
>> >
>> > Nope, can't do that. The packed struct is used for parsing data in
>> > memory.
>>
>> Okay, so I mixed this up with display/intel_opregion.c. So it's not used
>> for parsing here... but it's used for generating the data in memory, and
>> we can't change the layout or contents.
>>
>> Regardless, we can't do either patch 2 or patch 3.
>
> Thanks for review.
> So does it means the only "Fix" is to drop Werror, at least for intel/gvt
> code ?
Of course not. The fix is to address the warning.
There's another thread about this, see my suggestion there [1].
BR,
Jani.
[1] https://lore.kernel.org/r/87r02ma8s3....@intel.com
> I have CONFIG_DRM_I915_WERROR not set but CONFIG_DRM_WERROR=y, (same as
> Fedora)
> Unsure why the current Fedora kernel is unaffected by this build failure.
--
Jani Nikula, Intel
