> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: Wednesday, September 20, 2023 5:05 AM > To: Intel Wired LAN <[email protected]> > Cc: Keller, Jacob E <[email protected]>; Nguyen, Anthony L > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next 4/4] ice: cleanup > ice_find_netlist_node > > The ice_find_netlist_node function was introduced in commit 8a3a565ff210 > ("ice: add admin commands to access cgu configuration"). Variations of this > function were reviewed concurrently on both intel-wired-lan[1][2], and > netdev [3][4] > > [1]: > https://lore.kernel.org/intel-wired-lan/[email protected]/ > [2]: > https://lore.kernel.org/intel-wired-lan/[email protected]/ > [3]: > https://lore.kernel.org/netdev/[email protected]/ > [4]: > https://lore.kernel.org/netdev/[email protected]/ > > The variant I posted had a few changes due to review feedback which were > never incorporated into the DPLL series: > > * Replace the references to ancient and long removed ICE_SUCCESS and > ICE_ERR_DOES_NOT_EXIST status codes in the function comment. > > * Return -ENOENT instead of -ENOTBLK, as a more common way to indicate that > an entry doesn't exist. > > * Avoid the use of memset() and use simple static initialization for the > cmd variable. > > * Use FIELD_PREP to assign the node_type_ctx. > > * Remove an unnecessary local variable to keep track of rec_node_handle, > just pass the node_handle pointer directly into ice_aq_get_netlist_node. > > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_common.c | 30 ++++++++++----------- > 1 file changed, 15 insertions(+), 15 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
