> -----Original Message-----
> From: Lobakin, Aleksander <[email protected]>
> Sent: Wednesday, October 11, 2023 11:25 AM
> To: Loktionov, Aleksandr <[email protected]>
> Cc: [email protected]; Nguyen, Anthony L
> <[email protected]>; Jagielski, Jedrzej <[email protected]>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default
> speed
> when changed PHY doesn't support it
>
> From: Alexander Lobakin <[email protected]>
> Date: Wed, 11 Oct 2023 11:22:21 +0200
>
> > From: Aleksandr Loktionov <[email protected]>
> > Date: Wed, 11 Oct 2023 11:13:42 +0200
> >
> > Please add netdev and linux-kernel MLs to CCs when sending the next version.
Sure will do it in next version, thank you for the note
> >
> >> In order to avoid no link after plugging a different type PHY module.
> >
> > The sentence is incomplete, it tells "why", but no "what".
Please clarify your suggestion, what is your "what" expectations?
> >
> >>
> >> Add reset link speed settings to the default values for PHY module,
> >> if different PHY module is inserted and currently defined
> >> user-specified speed is not compatible with this module.
> >>
> >> Reviewed-by: Jedrzej Jagielski <[email protected]>
> >> Signed-off-by: Radoslaw Tyl <[email protected]>
> >
> > How did Radoslaw participate?
> > If he's the author, he must be in the "From" field as well. If not,
> > his SoB tells me nothing. Author, co-developer, reviewer, ...?
>
> Also, his email address bounces, IOW there's no point in adding this SoB. If
> you
> want to credit his work, use his working email, either private or dunno,
> otherwise makes no sense.
Can you explain what do you mean by 'IOW'?
Radek is original author of the patch for OOT driver which a had re-work to be
accepted for upstream. Now he is no longer works in Intel. I wanted to give him
a credit. What do you suggest?
> >
> >> Signed-off-by: Aleksandr Loktionov <[email protected]>
>
> [...]
>
> Thanks,
> Olek
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
