> -----Original Message-----
> From: Randy Dunlap <[email protected]>
> Sent: Thursday, October 12, 2023 8:47 AM
> To: Keller, Jacob E <[email protected]>; Lobakin, Aleksander
> <[email protected]>; David S. Miller <[email protected]>; Eric
> Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo
> Abeni <[email protected]>
> Cc: Michalik, Michal <[email protected]>; [email protected];
> Richard Cochran <[email protected]>; [email protected];
> Kubalewski, Arkadiusz <[email protected]>; intel-wired-
> [email protected]; Nguyen, Anthony L <[email protected]>; Olech,
> Milena <[email protected]>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined
> reference to
> tcp_gro_complete() when !CONFIG_INET
>
> Hi,
>
> On 9/20/23 18:30, Randy Dunlap wrote:
> >
> >
> > On 9/20/23 17:04, Jacob Keller wrote:
> >>
> >>
> >> On 9/20/2023 2:30 PM, Randy Dunlap wrote:
> >>>
> >>>
> >>> On 9/20/23 11:07, Alexander Lobakin wrote:
> >>>> When CONFIG_INET is not set, tcp_gro_complete is not compiled, although
> >>>> the drivers using it may still be compiled (spotted by Randy):
> >>>>
> >>>> aarch64-linux-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o:
> >>>> in function `idpf_rx_rsc.isra.0':
> >>>> drivers/net/ethernet/intel/idpf/idpf_txrx.c:2909:(.text+0x40cc):
> >>>> undefined reference to `tcp_gro_complete'
> >>>>
> >>>> The drivers need to guard the calls to it manually.
> >>>> Return early from the RSC completion function if !CONFIG_INET, it won't
> >>>> work properly either way. This effectively makes it be compiled-out
> >>>> almost entirely on such builds.
> >>>>
> >>>> Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
> >>>> Reported-by: Randy Dunlap <[email protected]>
> >>>> Closes: https://lore.kernel.org/linux-next/4c84eb7b-3dec-467b-934b-
> [email protected]
> >>>> Signed-off-by: Alexander Lobakin <[email protected]>
> >>>
> >>> That builds for me. Thanks.
> >>>
> >>> Tested-by: Randy Dunlap <[email protected]>
> >>>
> >>> I hope that these patches can be merged into the v6.6 instead of
> >>> v6.7 kernel at some point (i.e., [PATCH net] instead of net-next).
> >>>
> >>
> >> Did any of the offending code make it into 6.6? I thought all of this
> >> was from recent merges after 6.6 closed.
> >>
> >> Thanks,
> >> Jake
> >
> > Oh, I think that you are correct. Sorry about my comment.
> > Thanks.
> >
>
> Even if this is just > v6.6 kernels (i.e., linux-next),
> it would be very good to get a fix merged for these build errors.
> I keep getting build errors in linux-next....
>
A standalone version for the idpf driver fix was posted at [1], and another
alternative fix was posted at [2]
Fixes for the ice driver have already merged.
[1]:
https://lore.kernel.org/netdev/[email protected]/
[2]: https://lore.kernel.org/netdev/[email protected]/
The fix from Arnd got approval from Olek, but it seems like it stalled out
after asking about stubs. I'm fine with either approach but would also like to
see a fix merge soon.
Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
