On 18. 10. 23 17:11, Michal Schmidt wrote:
On Wed, Oct 18, 2023 at 1:26 PM Drewek, Wojciech
<[email protected]> wrote:
-----Original Message-----
From: Michal Schmidt<[email protected]>
Sent: Wednesday, October 18, 2023 1:15 PM
To:[email protected]
Cc: Keller, Jacob E<[email protected]>; Drewek, Wojciech
<[email protected]>; Brandeburg, Jesse
<[email protected]>; Nguyen, Anthony L
<[email protected]>;[email protected]
Subject: [PATCH net-next] iavf: delete unused iavf_mac_info fields
'san_addr' and 'mac_fcoeq' members of struct iavf_mac_info are unused.
'type' is write-only. Delete all three.
The function iavf_set_mac_type that sets 'type' also checks if the PCI
vendor ID is Intel. This is unnecessary. Delete the whole function.
If in the future there's a need for the MAC type (or other PCI
ID-dependent data), I would prefer to use .driver_data in iavf_pci_tbl[]
for this purpose.
Signed-off-by: Michal Schmidt<[email protected]>
Reviewed-by: Wojciech Drewek<[email protected]>
Nice cleanup, I've seen similar unused fields in i40e as well.
Any plans for i40e cleanup?
No, I am not planning to look into i40e cleanups in the near future.
Ivan might want to do that though. [Adding him to the thread]
Michal
OK, I will do it...
Thanks,
Ivan
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
