On 24.10.2023 15:01, Ivan Vecera wrote: > > > On 24. 10. 23 12:24, Wojciech Drewek wrote: >> On 23.10.2023 18:29, Ivan Vecera wrote: >>> Add another helper functions that will be used by subsequent >>> patch to refactor existing open-coded checks whether the version >>> of running firmware and AdminQ API is recent enough to provide >>> certain capabilities. >>> >>> Signed-off-by: Ivan Vecera<[email protected]> >>> --- >>> drivers/net/ethernet/intel/i40e/i40e_type.h | 54 +++++++++++++++++++++ >>> 1 file changed, 54 insertions(+) >>> >>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h >>> b/drivers/net/ethernet/intel/i40e/i40e_type.h >>> index 050d479aeed3..bb62c14aa3d4 100644 >>> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h >>> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h >>> @@ -608,6 +608,60 @@ static inline bool i40e_is_aq_api_ver_ge(struct >>> i40e_hw *hw, u16 maj, u16 min) >>> (hw->aq.api_maj_ver == maj && hw->aq.api_min_ver >= min)); >>> } >>> +/** >>> + * i40e_is_aq_api_ver_lt >>> + * @hw: pointer to i40e_hw structure >>> + * @maj: API major value to compare >>> + * @min: API minor value to compare >>> + * >>> + * Assert whether current HW API version is less than provided. >>> + **/ >>> +static inline bool i40e_is_aq_api_ver_lt(struct i40e_hw *hw, u16 maj, u16 >>> min) >>> +{ >>> + return !i40e_is_aq_api_ver_ge(hw, maj, min); >>> +} >> It feels a bit off to have those helpers in i40e_type.h. >> We don't have i40e_common.h though so I'd move them to i40e_prototype.h or >> i40e.h. >> Same comment regarding 1st patch (I know I gave it my tag but I spotted the >> issue >> while reading the 2nd patch). > > I'm sorry I already submitted v2 and helpers are present i40e_type.h. > I would submit v3 but there is also i40e_is_vf() inline function already > present in i40e_type. Would you be OK with a follow-up that would move all > these inlines into i40e_prototype.h?
Sounds good > > Btw i40e.h is not a good idea as this would bring a dependency on i40e.h into > i40e_adminq.c, i40e_common.c and i40e_dcb.c. Got it > > Regards, > Ivan > > _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
