> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Paul > Greenwalt > Sent: Tuesday, November 7, 2023 11:02 PM > To: [email protected] > Cc: Nowlin, Dan <[email protected]>; Fijalkowski, Maciej > <[email protected]>; [email protected]; Brandeburg, Jesse > <[email protected]>; Keller, Jacob E <[email protected]>; > Nguyen, Anthony L <[email protected]>; Greenwalt, Paul > <[email protected]>; [email protected]; Drewek, Wojciech > <[email protected]>; [email protected]; [email protected] > Subject: [Intel-wired-lan] [PATCH iwl-net v3] ice: fix DDP package download > for packages without signature segment > > From: Dan Nowlin <[email protected]> > > Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment") > incorrectly removed support for package download for packages without a > signature segment. These packages include the signature buffer inline in the > configurations buffers, and not in a signature segment. > > Fix package download by providing download support for both packages with > (ice_download_pkg_with_sig_seg()) and without signature segment > (ice_download_pkg_without_sig_seg()). > > Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment") > Reported-by: Maciej Fijalkowski <[email protected]> > Closes: https://lore.kernel.org/netdev/ZUT50a94kk2pMGKb@boxer/ > Tested-by: Maciej Fijalkowski <[email protected]> > Reviewed-by: Wojciech Drewek <[email protected]> > Reviewed-by: Jacob Keller <[email protected]> > Signed-off-by: Dan Nowlin <[email protected]> > Signed-off-by: Paul Greenwalt <[email protected]> > --- > Changelog > v2->v3: > - correct Changelog version tag, add Closes, Tested-by and Reviewed-by. > Remove unnecessary local variable initialization in ice_dwnld_cfg_bufs(), > and unnecessary local variable in ice_download_pkg_without_sig_seg(), > v1->v2: > - correct Reported-by email address. > --- > drivers/net/ethernet/intel/ice/ice_ddp.c | 103 ++++++++++++++++++++++- > 1 file changed, 100 insertions(+), 3 deletions(-) >
Tested-by: Arpana Arland <[email protected]> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
