> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Simon Horman > Sent: Friday, November 3, 2023 6:09 PM > To: ivecera <[email protected]> > Cc: Drewek, Wojciech <[email protected]>; > [email protected]; Brandeburg, Jesse <[email protected]>; > [email protected]; Eric Dumazet <[email protected]>; > Nguyen, Anthony L <[email protected]>; intel-wired- > [email protected]; Keller, Jacob E <[email protected]>; Jakub > Kicinski > <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking > fields from iavf_adminq_ring > > On Thu, Oct 26, 2023 at 10:39:32AM +0200, Ivan Vecera wrote: > > Fields 'head', 'tail', 'len', 'bah' and 'bal' in iavf_adminq_ring are > > used to store register offsets. These offsets are initialized and > > remains constant so there is no need to store them in the > > iavf_adminq_ring structure. > > > > Remove these fields from iavf_adminq_ring and use register offset > > constants instead. Remove iavf_adminq_init_regs() that originally > > stores these constants into these fields. > > > > Finally improve iavf_check_asq_alive() that assumes that non-zero > > value of hw->aq.asq.len indicates fully initialized AdminQ send queue. > > Replace it by check for non-zero value of field hw->aq.asq.count that > > is non-zero when the sending queue is initialized and is zeroed during > > shutdown of the queue. > > > > Signed-off-by: Ivan Vecera <[email protected]> > > Thanks, this is a nice cleanup. > > Reviewed-by: Simon Horman <[email protected]> > > ... > _______________________________________________ > Intel-wired-lan mailing list > [email protected] > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by: Rafal Romanowski <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
