From: Nguyen, Anthony L <[email protected]> Sent: Friday, November 17, 2023 12:36 AM
>On 11/14/2023 1:10 AM, Jedrzej Jagielski wrote: >> Currently ixgbe driver is notified of overheating events >> via internal IXGBE_ERR_OVERTEMP erorr code. >> >> Change the approach to use is_overhaet variable >> which set when such event occurs. > >I'll likely have more questions/comments, but an initial question. Is >this variable intended to hold the state of the PHY as overheated or is >this just communicating at the time of the check that it's overheated? My intention was to introduce this variable in order to inform the calling function, not to hold the state, that's why it's cleared right after overtemp detected. So basically it is IXGBE_ERR_OVERTEMPworkaround. Actually i could add dedicated parameter to phy.ops.check_overtemp() and phy.ops.handle_lasi() but I choose not to interfere with their declarations and decided to add this variable. If you have any advices please share. > >> Reviewed-by: Przemek Kitszel <[email protected]> >> Signed-off-by: Jedrzej Jagielski <[email protected]> >> --- >> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 +++++++----- >> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 7 +++++-- >> drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 2 +- >> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 19 +++++++++---------- >> 4 files changed, 22 insertions(+), 18 deletions(-) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
