On Fri, Nov 24, 2023 at 12:41:54PM +0100, Karol Kolacinski wrote:
> Schedule service task and EXTTS in the top half to avoid bottom half
> scheduling if possible, which significantly reduces timestamping delay.
>
> Co-developed-by: Michal Michalik <[email protected]>
> Signed-off-by: Michal Michalik <[email protected]>
> Signed-off-by: Karol Kolacinski <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 1 -
> drivers/net/ethernet/intel/ice/ice_main.c | 18 ++++++++++--------
> 2 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice.h
> b/drivers/net/ethernet/intel/ice/ice.h
> index 3ea33947b878..d5a8da0c02c3 100644
> --- a/drivers/net/ethernet/intel/ice/ice.h
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -517,7 +517,6 @@ enum ice_pf_flags {
> };
>
> enum ice_misc_thread_tasks {
> - ICE_MISC_THREAD_EXTTS_EVENT,
> ICE_MISC_THREAD_TX_TSTAMP,
> ICE_MISC_THREAD_NBITS /* must be last */
> };
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index 1f159b4362ec..6b91ec6f420d 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -3078,6 +3078,7 @@ static void ice_ena_misc_vector(struct ice_pf *pf)
> static irqreturn_t ice_misc_intr(int __always_unused irq, void *data)
> {
> struct ice_pf *pf = (struct ice_pf *)data;
> + irqreturn_t ret = IRQ_HANDLED;
> struct ice_hw *hw = &pf->hw;
> struct device *dev;
> u32 oicr, ena_mask;
> @@ -3161,6 +3162,8 @@ static irqreturn_t ice_misc_intr(int __always_unused
> irq, void *data)
> ena_mask &= ~PFINT_OICR_TSYN_TX_M;
> if (ice_ptp_pf_handles_tx_interrupt(pf))
Hi Karol,
it seems that a trailing '{' is missing from the line above.
> set_bit(ICE_MISC_THREAD_TX_TSTAMP, pf->misc_thread);
> + ret = IRQ_WAKE_THREAD;
> + }
> }
>
> if (oicr & PFINT_OICR_TSYN_EVNT_M) {
...
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
