Tue, Nov 28, 2023 at 06:45:47PM CET, [email protected] wrote: > > >> From: Jiri Pirko <[email protected]> >> Sent: Monday, November 27, 2023 11:38 PM >> To: Bahadur, Sachin <[email protected]> >> Cc: [email protected]; [email protected]; linux- >> [email protected] >> Subject: Re: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond >> >> Mon, Nov 27, 2023 at 05:23:55PM CET, [email protected] wrote: >> > >> >> Nack. Remove the netdev during re-init, that would solve your issue. >> >> Looks like some checks are needed to be added in devlink code to make >> >> sure drivers behave properly. I'm on in. >> > >> >Sure. This fix should apply to all drivers. Adding it in devlink makes >> >more sense. I am not a devlink expert, so I hope you or someone else >> >can help with it. >> >> No, you misunderstood. I'll just add a check-warn in devlink for case when >> port >> exists during reload. You need to fix it in your driver. > > >What should be fixed in my driver. Can you clarify ? >And are suggesting I add the check-warn in devlink code ?
Remove the netdev during re-init. > > >> > >> >> >> >> >> >> >+ return -EBUSY; >> >> >+ } >> >> > ice_unload(pf); >> >> > return 0; >> >> > case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: >> >> >-- >> >> >2.25.1 >> >> > >> >> > _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
