On 11/29/2023 9:56 AM, Sachin Bahadur wrote:
> Print NIC FW version during PF initialization. FW version in dmesg is used
> to identify and isolate issues. Particularly useful when dmesg is read
> after reboot.
>
> Example log from dmesg:
> ice 0000:ca:00.0: fw 6.2.9 api 1.7.9 nvm 3.32 0x8000d83e 1.3146.0
>
> Reviewed-by: Paul Menzel <[email protected]>
> Reviewed-by: Pawel Kaminski <[email protected]>
> Signed-off-by: Sachin Bahadur <[email protected]>
> ---
> v1->v2: Added example log message
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index 1f159b4362ec..71d3d8cfdd1d 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -4568,6 +4568,12 @@ static int ice_init_dev(struct ice_pf *pf)
> dev_err(dev, "ice_init_hw failed: %d\n", err);
> return err;
> }
> + dev_info(dev, "fw %u.%u.%u api %u.%u.%u nvm %u.%u 0x%08x %u.%u.%u\n",
> + hw->fw_maj_ver, hw->fw_min_ver, hw->fw_patch, hw->api_maj_ver,
> + hw->api_min_ver, hw->api_patch, hw->flash.nvm.major,
> + hw->flash.nvm.minor, hw->flash.nvm.eetrack,
> + hw->flash.orom.major, hw->flash.orom.build,
> + hw->flash.orom.patch);
>
Seems ok. I guess we print something like this in a lot of our drivers
already.
devlink info reports most of this as well though with more verbose naming:
pci/0000:af:00.0:
driver ice
serial_number 00-01-00-ff-ff-00-00-00
versions:
fixed:
board.id K91258-000
running:
fw.mgmt 6.1.5
fw.mgmt.api 1.7.9
fw.mgmt.build 0x6986bfdb
fw.undi 1.3025.0
fw.psid.api 3.10
fw.bundle_id 0x80008e6a
fw.app.name ICE OS Default Package
fw.app 1.3.35.0
fw.app.bundle_id 0xc0000001
fw.netlist 3.10.2000-3.1e.0
fw.netlist.build 0x4154dfac
stored:
fw.undi 1.3025.0
fw.psid.api 3.10
fw.bundle_id 0x80008e6a
fw.netlist 3.10.2000-3.1e.0
fw.netlist.build 0x4154dfac
But I guess a succinct log could be useful to have when reviewing a bug
report from customers who just copy the kernel log.
> /* Some cards require longer initialization times
> * due to necessity of loading FW from an external source.
> --
> 2.25.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> [email protected]
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
