On Wed, Nov 29, 2023 at 02:36:11AM -0500, Jan Glaza wrote: > Add const modifier to function parameters and variables where appropriate > in ice_base.c and corresponding declarations in ice_base.h. > > The reason for starting the change is that read-only pointers should be > marked as const when possible to allow for smoother and more optimal code > generation and optimization as well as allowing the compiler to warn the > developer about potentially unwanted modifications, while not carrying > noticable negative impact.
Hi Jan, it's probably not worth respinning for this, but: noticeable > > Reviewed-by: Andrii Staikov <[email protected]> > Reviewed-by: Sachin Bahadur <[email protected]> > Signed-off-by: Jan Glaza <[email protected]> > --- > This change is done in one file to get comment feedback and, if positive, > will be rolled out across the entire ice driver code. The nit above notwithstanding, this looks good to me. Reviewed-by: Simon Horman <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
