From: Nguyen, Anthony L <[email protected]> Sent: Friday, December 8, 2023 12:17 AM
>On 12/5/2023 3:28 AM, Jedrzej Jagielski wrote: >> Currently ixgbe driver is notified of overheating events via internal >> IXGBE_ERR_OVERTEMP error code. >> >> Change the approach to use freshly introduced is_overtemp function >> parameter which set when such event occurs. >> Add new parameter to the check_overtemp() and handle_lasi() phy ops. > >These patches don't apply. There are also checkpatch warnings on this. WARNING: function definition argument 'struct ixgbe_hw *' should also have an identifier name #186: FILE: drivers/net/ethernet/intel/ixgbe/ixgbe_type.h:3512: + s32 (*check_overtemp)(struct ixgbe_hw *, bool *); I am aware of these warnings but that is common that ops are declared without specifying name of function params in ixgbe driver so i just kept that rule. > >> Signed-off-by: Jedrzej Jagielski <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
