Thanks for the reminder. It was my negligence.
I'll resend the v5 patch:
1. Keep 'Signed-off-by' be the last tag in the block
2. Cc to '[email protected]'
3. Cc to my personal email '[email protected]'
Thanks again,
Kunwu
On 2023/12/8 07:25, Tony Nguyen wrote:
On 12/6/2023 4:40 AM, Alexander Lobakin wrote:
From: Kunwu Chan <[email protected]>
Date: Tue, 5 Dec 2023 17:58:44 +0800
The size of "i40e_dbg_command_buf" is 256, the size of "name"
depends on "IFNAMSIZ", plus a null character and format size,
the total size is more than 256.
Improve readability and maintainability by replacing a hardcoded string
allocation and formatting by the use of the kasprintf() helper.
Fixes: 02e9c290814c ("i40e: debugfs interface")
Signed-off-by: Kunwu Chan <[email protected]>
Suggested-by: Simon Horman <[email protected]>
Suggested-by: Alexander Lobakin <[email protected]>
Your Signed-off-by must be the last tag in the block.
Perhaps the maintainer could fix it when taking, so that you wouldn't
need to send a new version only due to that.
You missed Intel Wired LAN ([email protected]) on this,
though the other versions did have it. Could you fix this up and be sure
to include Intel Wired LAN?
Thanks,
Tony
---
v2
- Update the size calculation with IFNAMSIZ and
sizeof(i40e_dbg_command_buf)
v3
- Use kasprintf to improve readability and maintainability
v4
- Fix memory leak in error path
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
