> -----Original Message----- > From: Nguyen, Anthony L <[email protected]> > Sent: Friday, December 8, 2023 1:18 PM > To: Ertman, David M <[email protected]>; intel-wired- > [email protected] > Cc: [email protected]; Brandeburg, Jesse > <[email protected]> > Subject: Re: [PATCH iwl-next] ice: alter feature support check for SRIOV and > LAG > > > > On 12/7/2023 10:21 AM, Dave Ertman wrote: > > Previously, the ice driver had support for using a hanldler for bonding > > netdev events to ensure that conflicting features were not allowed to be > > activated at the same time. While this was still in place, additional > > support was added to specifically support SRIOV and LAG together. These > > both utilized the netdev event handler, but the SRIOV and LAG feature was > > behind a capabilities feature check to make sure the current NVM has > > support. > > > > The exclusion part of the event handler should be removed since there are > > users who have custom made solutions that depend on the non-exclusion > of > > features. > > > > Wrap the creation/registration and cleanup of the event handler and > > associated structs in the probe flow with a feature check so that the > > only systems that support the full implementation of LAG features will > > initialize support. This will leave other systems unhindered with > > functionality as it existed before any LAG code was added. > > This sounds like a bug fix? Should it be for iwl-net? >
To my knowledge, this issue has not been reported by any users and was found through code inspection. Would you still recommend iwl-net? DaveE > > Reviewed-by: Jesse Brandeburg <[email protected]> > > Signed-off-by: Dave Ertman <[email protected]> > > --- > > drivers/net/ethernet/intel/ice/ice_lag.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c > b/drivers/net/ethernet/intel/ice/ice_lag.c > > index 280994ee5933..b47cd43ae871 100644 > > --- a/drivers/net/ethernet/intel/ice/ice_lag.c > > +++ b/drivers/net/ethernet/intel/ice/ice_lag.c > > @@ -1981,6 +1981,8 @@ int ice_init_lag(struct ice_pf *pf) > > int n, err; > > > > ice_lag_init_feature_support_flag(pf); > > + if (!ice_is_feature_supported(pf, ICE_F_SRIOV_LAG)) > > + return 0; > > > > pf->lag = kzalloc(sizeof(*lag), GFP_KERNEL); > > if (!pf->lag) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
