> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Michal Schmidt > Sent: Thursday, November 30, 2023 10:28 PM > To: [email protected] > Cc: Nguyen, Anthony L <[email protected]>; Greenwalt, Paul > <[email protected]>; [email protected]; Brandeburg, > Jesse <[email protected]> > Subject: [Intel-wired-lan] [PATCH net] ice: fix theoretical out-of-bounds > access in ethtool link modes > > To map phy types reported by the hardware to ethtool link mode bits, > ice uses two lookup tables (phy_type_low_lkup, phy_type_high_lkup). > The "low" table has 64 elements to cover every possible bit the hardware > may report, but the "high" table has only 13. If the hardware reports a > higher bit in phy_types_high, the driver would access memory beyond the > lookup table's end. > > Instead of iterating through all 64 bits of phy_types_{low,high}, use > the sizes of the respective lookup tables. > > Fixes: 9136e1f1e5c3 ("ice: refactor PHY type to ethtool link mode") > Signed-off-by: Michal Schmidt <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
