> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Kunwu > Chan > Sent: Friday, December 8, 2023 8:50 AM > To: Brandeburg, Jesse <[email protected]>; Nguyen, Anthony L > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Cc: Kunwu Chan <[email protected]>; Kunwu Chan <[email protected]>; > [email protected]; [email protected]; Lobakin, Aleksander > <[email protected]>; [email protected]; Simon > Horman <[email protected]> > Subject: [Intel-wired-lan] [PATCH v5 iwl-next] i40e: Use correct buffer size > in i40e_dbg_command_read > > The size of "i40e_dbg_command_buf" is 256, the size of "name" > depends on "IFNAMSIZ", plus a null character and format size, > the total size is more than 256. > > Improve readability and maintainability by replacing a hardcoded string > allocation and formatting by the use of the kasprintf() helper. > > Fixes: 02e9c290814c ("i40e: debugfs interface") > Suggested-by: Simon Horman <[email protected]> > Suggested-by: Alexander Lobakin <[email protected]> > Suggested-by: Tony Nguyen <[email protected]> > Cc: Kunwu Chan <[email protected]> > Signed-off-by: Kunwu Chan <[email protected]> > --- > v2 > - Update the size calculation with IFNAMSIZ and > sizeof(i40e_dbg_command_buf) > v3 > - Use kasprintf to improve readability and maintainability > v4 > - Fix memory leak in error path > v5 > - Change the order of labels > --- > .../net/ethernet/intel/i40e/i40e_debugfs.c | 20 ++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
