On 12/19/2023 6:35 PM, Brett Creeley wrote:
On 12/13/2023 8:34 PM, Lukasz Plachno wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
From: Jakub Buchocki <[email protected]>
Add support for 'flow-type ether' Flow Director rules via ethtool.
Rules not containing masks are processed by the Flow Director,
and support the following set of input parameters in all combinations:
src, dst, proto, vlan-etype, vlan, action.
It is possible to specify address mask in ethtool parameters but only
00:00:00:00:00 and FF:FF:FF:FF:FF are valid.
The same applies to proto, vlan-etype and vlan masks:
only 0x0000 and 0xffff masks are valid.
Would it be useful to have user facing error messages for invalid masks
stating what the valid masks are?
Do you think about something like:
dev_warn("Driver only supports masks 00:00:00:00:00:00 and
FF:FF:FF:FF:FF:FF"),
or there is a way to pass custom message to ethtool to print it to user?
Signed-off-by: Jakub Buchocki <[email protected]>
Co-developed-by: Mateusz Pacuszka <[email protected]>
Signed-off-by: Mateusz Pacuszka <[email protected]>
Reviewed-by: Przemek Kitszel <[email protected]>
Signed-off-by: Lukasz Plachno <[email protected]>
---
.../net/ethernet/intel/ice/ice_ethtool_fdir.c | 128 +++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_fdir.c | 27 ++++
drivers/net/ethernet/intel/ice/ice_fdir.h | 11 ++
drivers/net/ethernet/intel/ice/ice_type.h | 1 +
4 files changed, 166 insertions(+), 1 deletion(-)
[...]
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
