On Wed, Dec 20, 2023 at 06:38:37PM +0100, Aleksandr Loktionov wrote:
> Add trace events related to SFP module IOCTLs for troubleshooting.
>
> Example:
> echo "i40e_*" >/sys/kernel/tracing/set_ftrace_filter
> echo "i40e_ioctl*" >/sys/kernel/tracing/events/i40e/filter
> echo 1 >/sys/kernel/tracing/tracing_on
> echo 1 >/sys/kernel/tracing/events/i40e/enable
> ...
> cat /sys/kernel/tracing/trace
>
> Riewed-by: Przemek Kitszel <[email protected]>
> Signed-off-by: Aleksandr Loktionov <[email protected]>
> ---
> v1->v2 applied to proper git branch
> ---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 5 +++++
> drivers/net/ethernet/intel/i40e/i40e_trace.h | 18 ++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index c841779..bdf2b6b 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -1074,6 +1074,7 @@ static int i40e_get_link_ksettings(struct net_device
> *netdev,
> ethtool_link_ksettings_zero_link_mode(ks, supported);
> ethtool_link_ksettings_zero_link_mode(ks, advertising);
>
> + i40e_trace(ioctl_get_link_ksettings, pf, hw_link_info->link_info);
> if (link_up)
> i40e_get_settings_link_up(hw, ks, netdev, pf);
> else
Hi Aleksandr,
I think that i40e_trace.h needs to be included in i40e_ethtool.c
as part of this patch.
.../i40e_ethtool.c: In function ‘i40e_get_link_ksettings’:
.../i40e_ethtool.c:1077:9: error: implicit declaration of function
‘i40e_trace’ [-Werror=implicit-function-declaration]
1077 | i40e_trace(ioctl_get_link_ksettings, pf,
hw_link_info->link_info);
| ^~~~~~~~~~
...
Flagged by gcc-13 W=1 build
...
--
pw-bot: changes-requested
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
