> -----Original Message-----
> From: Sokolowski, Jan <[email protected]>
> Sent: Thursday, December 21, 2023 2:20 AM
> To: Kolacinski, Karol <[email protected]>;
> [email protected]
> Cc: [email protected]; Nguyen, Anthony L <[email protected]>;
> Brandeburg, Jesse <[email protected]>; Keller, Jacob E
> <[email protected]>; Kolacinski, Karol <[email protected]>
> Subject: RE: [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()
>
> >From: Jacob Keller <[email protected]>
> >
> >The ice_ptp_reset() function uses a goto to skip past clock owner
> >operations if performing a PF reset or if the device is not the clock
> >owner. This is a bit confusing. Factor this out into
> >ice_ptp_rebuild_owner() instead.
>
> To me at least, the wording of the title (Factor out) is kinda
> confusing when compared to the message itself, as if you were going
> to remove the ice_ptp_rebuild_owner anyway.
>
> Other than that, LGTM.
>
Ya, the idea is to split the functionality into a separate function.
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
