> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Pavan Kumar Linga > Sent: Friday, December 15, 2023 3:48 PM > To: [email protected] > Cc: [email protected]; Lobakin, Aleksander > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Zaremba, Larysa > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: avoid compiler introduced > padding in virtchnl2_rss_key struct > > Size of the virtchnl2_rss_key struct should be 7 bytes but the > compiler introduces a padding byte for the structure alignment. > This results in idpf sending an additional byte of memory to the device > control plane than the expected buffer size. As the control plane > enforces virtchnl message size checks to validate the message, > set RSS key message fails resulting in the driver load failure. > > Remove implicit compiler padding by using "__packed" structure > attribute for the virtchnl2_rss_key struct. > > Also there is no need to use __DECLARE_FLEX_ARRAY macro for the > 'key_flex' struct field. So drop it. > > Fixes: 0d7502a9b4a7 ("virtchnl: add virtchnl version 2 ops") > Reviewed-by: Larysa Zaremba <[email protected]> > Signed-off-by: Pavan Kumar Linga <[email protected]> > --- > drivers/net/ethernet/intel/idpf/virtchnl2.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
Tested-by: Scott Register <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
