> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Jesse Brandeburg > Sent: Tuesday, December 5, 2023 5:01 PM > To: [email protected] > Cc: Kitszel, Przemyslaw <[email protected]>; Brandeburg, Jesse > <[email protected]>; Lobakin, Aleksander > <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: [Intel-wired-lan] [PATCH iwl-next v2 15/15] idpf: refactor some > missing field get/prep conversions > > Most of idpf correctly uses FIELD_GET and FIELD_PREP, but a couple spots > were missed so fix those. > > Automated conversion with coccinelle script and manually fixed up, > including audits for opportunities to convert to {get,encode,replace} > bits functions. > > Add conversions to le16_get/encode/replace_bits where appropriate. And > in one place fix up a cast from a u16 to a u16. > > @prep2@ > constant shift,mask; > type T; > expression a; > @@ > -(((T)(a) << shift) & mask) > +FIELD_PREP(mask, a) > > @prep@ > constant shift,mask; > type T; > expression a; > @@ > -((T)((a) << shift) & mask) > +FIELD_PREP(mask, a) > > @get@ > constant shift,mask; > type T; > expression a; > @@ > -((T)((a) & mask) >> shift) > +FIELD_GET(mask, a) > > and applied via: > spatch --sp-file field_prep.cocci --in-place --dir \ > drivers/net/ethernet/intel/ > > CC: Alexander Lobakin <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Jesse Brandeburg <[email protected]> > --- > v2: merged this patch into larger series, modified after Olek's comments > to include bits encoding where changing lines for prep or get. > --- > .../ethernet/intel/idpf/idpf_singleq_txrx.c | 7 +-- > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 58 +++++++++---------- > 2 files changed, 30 insertions(+), 35 deletions(-)
Tested-by: Scott Register <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
