> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Thursday, December 21, 2023 2:49 PM > To: Staikov, Andrii <[email protected]>; > [email protected] > Cc: Ostrowska, Karen <[email protected]>; [email protected]; > Drewek, Wojciech <[email protected]>; Mateusz Palczewski > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v5] i40e: Restore VF MSI-X state > during PCI reset > > On 12/21/23 14:27, Andrii Staikov wrote: > > During a PCI FLR the MSI-X Enable flag in the VF PCI MSI-X capability > > register will be cleared. This can lead to issues when a VF is > > assigned to a VM because in these cases the VF driver receives no > > indication of the PF PCI error/reset and additionally it is incapable > > of restoring the cleared flag in the hypervisor configuration space > > without fully reinitializing the driver interrupt functionality. > > > > Since the VF driver is unable to easily resolve this condition on its > > own, restore the VF MSI-X flag during the PF PCI reset handling. > > > > Fixes: 19b7960b2da1 ("i40e: implement split PCI error reset handler") > > Co-developed-by: Karen Ostrowska <[email protected]> > > Signed-off-by: Karen Ostrowska <[email protected]> > > Co-developed-by: Mateusz Palczewski <[email protected]> > > Signed-off-by: Mateusz Palczewski <[email protected]> > > Reviewed-by: Wojciech Drewek <[email protected]> > > Reviewed-by: Przemyslaw Kitszel <[email protected]> > > should be "Przemek", but no need to send next version for that (but pls > promise it's last time ;)) > > > Signed-off-by: Andrii Staikov <[email protected]> > > --- > > v1 -> v2: Fix signed-off tags > > https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20231204131 > > [email protected]/ > > > > v2 -> v3: use @vf_dev in pci_get_device() instead of NULL and remove > > unnecessary call > > https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20231206125 > > [email protected]/ > > > > v3 -> v4: wrap the added functionality into the CONFIG_PCI_IOV define > > as this is VF-related functionality > > https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20231212122 > > [email protected]/ > > > > v4 -> v5: fix RB tags > > there was a question in v4 from Jake to "perhaps do it like in ice", but I > think > that for a bug fix it's better to keep this patch as-is (review always > welcomed > through). > > > --- > > drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++ > > .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 26 +++++++++++++++++++ > > .../ethernet/intel/i40e/i40e_virtchnl_pf.h | 3 +++ > > 3 files changed, 32 insertions(+) > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > > b/drivers/net/ethernet/intel/i40e/i40e_main.c > > index 7bb1f64833eb..bbe2d115fb15 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
Tested-by: Rafal Romanowski <[email protected]>
