Thanks for this patch! On Thu, Jan 18, 2024 at 02:43:31PM +0100, Jedrzej Jagielski wrote: > Converting s32 functions to regular int in the patch 8035560dbfaf caused > trigerring smatch warnings about missing error code. The bug predates > the mentioned patch.
It's not really a bug, just some suspicous code. Especially the "If 10G disabled for LPLU via NVM D10GMP, then return no valid LCD" return. But it's actually all fine so this patch is really just a cleanup. > > New smatch warnings: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() > warn: missing error code? 'status' > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 > ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status' > > Old smatch warnings: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() > warn: missing error code? 'status' > > Fix it by clearly stating returning error code as 0. > > Reported-by: kernel test robot <[email protected]> > Reported-by: Dan Carpenter <[email protected]> > Closes: https://lore.kernel.org/r/[email protected]/ > Fixes: 6ac743945960 ("ixgbe: Add support for entering low power link up > state") No need for a Fixes tag. > Signed-off-by: Jedrzej Jagielski <[email protected]> Thanks, again. I do think this makes it a lot more clear. regards, dan carpenter
